fix: fix uniswap integration and add swap type support with Uniswap exact-output and slippage controls#30
Merged
ggonzalez94 merged 3 commits intomainfrom Feb 25, 2026
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 65592eafe5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swap quote --typewithexact-input|exact-output(defaultexact-input)--amount-out/--amount-out-decimaltrade_typeto swap quote rows--slippage-pctfor Uniswap, and now fail fast for other providers to avoid silent ignores1inch,jupiter,fibrous,bungeeremain exact-input only)Validation
go test ./...go test -race ./...go vet ./...cd docs && npx --yes mint@4.2.378 validatecd docs && npx --yes mint@4.2.378 broken-linksSmoke checks
--amount-outand--amount-out-decimalunsupported(exit code13)2)Note
Medium Risk
Touches swap quote request/response schema and provider integrations (notably Uniswap), which can affect automation consumers and quote correctness; changes are well-covered by new unit tests but still impact a core CLI path.
Overview
Adds swap quote trade-type support via
--type exact-input|exact-outputplus exact-output amount flags (--amount-out,--amount-out-decimal), and returnstrade_typeon all swap quote rows.Updates CLI routing/validation so EVM exact-output defaults to
uniswap(Solana exact-output rejected), enforces--slippage-pctas a Uniswap-only manual override, and incorporates these inputs into the swap quote cache key.Fixes the Uniswap Trade API integration by sending required fields (
swapper,autoSlippage/slippageTolerance) and handling string-encoded gas USD fields; other providers now explicitly reject non-exact-inputrequests. Docs/README/CHANGELOG are updated and extensive provider/runner tests were added for new behaviors.Written by Cursor Bugbot for commit 0f4db41. This will update automatically on new commits. Configure here.