Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 817b8127c8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| at_minute: 'à la minute', | ||
| at_second: 'à la seconde', | ||
| until: "jusqu'à", | ||
| until: "jusqu'au", |
There was a problem hiding this comment.
The French formatter always emits the UNTIL date as ${monthName} ${day}, ${year} (see formatUntil around lines 790-792), so switching the token to "jusqu'au" yields outputs like “jusqu'au novembre 10, 2012,” which is ungrammatical because “au” requires an article (“au 10 novembre”) that never appears with this month-first format. With the current date ordering, the preposition needs to stay as "jusqu'à" (or the formatter must be changed to day-first) to avoid incorrect French output for every UNTIL rule.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af33291628
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/totext.ts
Outdated
| if (until) { | ||
| const monthName = data.monthNames[until.month - 1]!; | ||
| parts.push(data.words.until, `${monthName} ${until.day}, ${until.year}`); | ||
| if (locale === 'fr') { |
There was a problem hiding this comment.
The French date-order branch is gated by locale === 'fr', but this function already normalizes locale codes into lang and can be invoked with values like fr-FR (or with locale omitted while the runtime locale resolves to fr-FR). In those cases data is French but this condition is false, so UNTIL dates still render in English order (for example novembre 10, 2012) and miss the intended fix. Gate this branch on the normalized language or locale data instead.
Useful? React with 👍 / 👎.
2 participants
until