fix: normalize constructor parameters to prevent native/polyfill mixing#101
Merged
ggaabe merged 1 commit intoggaabe:mainfrom Jan 23, 2026
Merged
Conversation
The previous fix normalized Temporal objects during execution but missed constructor parameters. External libraries can pass native Temporal objects which were stored without normalization, causing type mismatches later. This adds a normalizeToPolyfill helper and applies it to dtstart and until in the constructor, ensuring consistent polyfill usage throughout the instance lifecycle.
Contributor
Author
|
@ggaabe Thanks for the super quick responses! 🙂 The new release now unblocks our migration to Electron v40. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon further investigation, I discovered that #100 did not cover all cases. So this completes the fix from #100 by addressing constructor parameters.
The Issue
The previous fix normalized Temporal objects during between() execution, but external libraries can pass native Temporal objects directly as constructor parameters. These were stored without normalization, causing type mismatches later during comparisons and until() operations.
The Solution