Skip to content

Refine tab icon refresh scheduling#219

Open
ewgdg wants to merge 2 commits intogfxholo:mainfrom
ewgdg:fix/tab-icon-retry-on-viewmode-change
Open

Refine tab icon refresh scheduling#219
ewgdg wants to merge 2 commits intogfxholo:mainfrom
ewgdg:fix/tab-icon-retry-on-viewmode-change

Conversation

@ewgdg
Copy link

@ewgdg ewgdg commented Feb 20, 2026

Summary

  • Coalesce tab icon refreshes so only one refresh runs per animation frame.
  • Gate refresh scheduling until layout is ready.
  • Refresh icons when a tab header's icon element is silently replaced without triggering a layout-change event.

Repro

  1. Install Iconic and obsidian-current-view (Current View) v1.4.0.
  2. Switch between tabs multiple times to trigger view mode changes.
  3. Observe the tab icon reset to default because Iconic does not reapply in that moment.

Testing

  • Manually tested tab/view switches in Obsidian; icons remain stable.

@ewgdg ewgdg marked this pull request as ready for review February 21, 2026 00:01
@ewgdg ewgdg force-pushed the fix/tab-icon-retry-on-viewmode-change branch from 1bb8633 to 14f30ac Compare February 21, 2026 00:32
@gfxholo gfxholo added bug Something isn't working performance Laggy behavior caused by the plugin labels Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working performance Laggy behavior caused by the plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants