Merged
Conversation
Member
|
Code's fine, just want crowlKats to give a +1 - @crowlKats merge if this is fine, please |
cwfitzgerald
approved these changes
May 29, 2024
crowlKats
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Part of #5641, split out to make it so that that PR is a non-breaking change.
Description
Remove the
linkfeature which is not available in theobjc2crates. This was added by@crowlKatsin #3853, but Deno doesn't actually use it, they instead specify this using-weak_framework, which is the correct solution to this problem IMO.Testing
Roughly as described in the changelog entry.
Checklist
cargo fmt.cargo clippy.cargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.