Fixed initial page extending on load. #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug with the extending page option, exemplified here: http://gregfranko.com/jquery.tocify.js/. On initial page load, if you hit the bottom link in the menu, 'Donation', you will see that the page doesn't actually scroll far enough and the extra padding div will not be added until the user has scrolled that far down. I've corrected this by removing the concept of the removing the concept of the extendPageOffset and added the padding div on load.
|
I can confirm that the pull request works. It would be nice if it could be merged in the dev or master version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving pull request to dev branch per request. There was a bug with the extending page option, exemplified here: http://gregfranko.com/jquery.tocify.js/. On initial page load, if you hit the bottom link in the menu, 'Donation', you will see that the page doesn't actually scroll far enough and the extra padding div will not be added until the user has scrolled that far down. I've corrected this by removing the concept of the removing the concept of the extendPageOffset and added the padding div on load.