Fix STR_SCENARIO_START_ID to allow WC_II_custom_terrain modification#10
Open
Adriankhl wants to merge 1 commit intogfgtdf:1.15from
Open
Fix STR_SCENARIO_START_ID to allow WC_II_custom_terrain modification#10Adriankhl wants to merge 1 commit intogfgtdf:1.15from
Adriankhl wants to merge 1 commit intogfgtdf:1.15from
Conversation
Author
|
I guess I should comment and modify the coming mainline version instead of this one. |
Owner
|
for the mainline version and most likely for the 1.15 aswell i will remove the custom terrain mod, since most of the changes it did were not yet mainline quality in my opinion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
utils/custom_terrain_mod.cfgthere is aallow_scenario= {STR_CAMPAIGN_WC_II_SCENARIOS_ID}However, the ID is defined as
World_Conquest_II_{PLAYERS_NUMBER}pinutils/strings/scenario.cfg,where it should be
WC_II_{PLAYERS}pinscenarios/WC_II_scenario.cfg