Fix false CRITICAL alerts for perpetual IronPort licenses#2
Open
jesusangel wants to merge 1 commit intogeuma:masterfrom
Open
Fix false CRITICAL alerts for perpetual IronPort licenses#2jesusangel wants to merge 1 commit intogeuma:masterfrom
jesusangel wants to merge 1 commit intogeuma:masterfrom
Conversation
The plugin was interpreting keySecondsUntilExpire=0 as an imminent expiration, triggering CRITICAL alerts for perpetual licenses. According to ASYNCOS-MAIL-MIB, perpetual licenses are explicitly identified via keyIsPerpetual, and may legitimately report keySecondsUntilExpire=0. This change preserves the SNMP table index and checks keyIsPerpetual before evaluating expiration thresholds, skipping expiration logic for perpetual licenses and preventing false positives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin was interpreting keySecondsUntilExpire=0 as an imminent expiration, triggering CRITICAL alerts for perpetual licenses.
According to ASYNCOS-MAIL-MIB, perpetual licenses are explicitly identified via keyIsPerpetual, and may legitimately report keySecondsUntilExpire=0.
This change preserves the SNMP table index and checks keyIsPerpetual before evaluating expiration thresholds, skipping expiration logic for perpetual licenses and preventing false positives.