ref: Remove gen_ai.tool.type assertions from test framework#137
Merged
ericapisani merged 1 commit intomainfrom Apr 8, 2026
Merged
ref: Remove gen_ai.tool.type assertions from test framework#137ericapisani merged 1 commit intomainfrom
ericapisani merged 1 commit intomainfrom
Conversation
Remove all references to the gen_ai.tool.type attribute: - Remove from checkToolSpanAttributes assertion - Remove type field from ExpectedToolCall interface and checkToolCalls validation - Remove type: "function" from tool-call test expectations - Remove gen_ai.tool.type setAttribute/set_data from manual agent templates Refs PY-2284 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🔴 AI SDK Integration Test ResultsStatus: 2 regressions detected Summary
🔴 RegressionsThese tests were passing on main but are now failing: cloudflare/vercel :: Conversation ID Agent Test (blocking, function, openai)Error: 1 check(s) failed: browser/langchain :: Multi-Turn LLM Test (streaming)Error: Browser test timed out (60s) ✅ FixedThese tests were failing on main but are now passing:
Test MatrixAgent Tests
Embedding Tests
LLM Tests
MCP Tests
Legend: ✅ Pass | ❌ Fail | ✅🔧 Fixed | ❌📉 Regressed | ✅🆕 New (pass) | ❌🆕 New (fail) | 🗑️ Removed | str=streaming blk=blocking a=async s=sync io=stdio sse=sse hi=highlevel lo=lowlevel Generated by AI SDK Integration Tests |
obostjancic
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all references to the
gen_ai.tool.typeattribute from the testing framework.This attribute is no longer part of the span conventions, so assertions on it
should be removed to avoid false failures as SDKs stop emitting it.
Changes:
gen_ai.tool.typefromcheckToolSpanAttributesassertiontypefield fromExpectedToolCallinterface andcheckToolCallsvalidationtype: "function"from tool-call test expectationsgen_ai.tool.typesetAttribute/set_data from manual agent templates (node + python)Fixes PY-2284