fix(apple): Rewind files after fetching from objectstore#1924
Merged
fix(apple): Rewind files after fetching from objectstore#1924
Conversation
8 tasks
jjbayer
commented
Apr 13, 2026
| use crate::{assert_snapshot, read_fixture, setup_service, symbol_server}; | ||
|
|
||
| #[tokio::test] | ||
| async fn test_attachment_download() { |
Member
Author
There was a problem hiding this comment.
There's a similar test in process_minidump.rs, but apple crash report downloads had no test coverage.
Without the fix in attachments.rs, this test fails with the same empty stack trace as we saw in #1884.
loewenheim
reviewed
Apr 13, 2026
This reverts commit 3de2a6a.
Member
Author
|
I split out the refactor to #1928 because it failed sentry tests for minidumps. |
loewenheim
approved these changes
Apr 14, 2026
Contributor
|
This deserves a changelog entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloads from objectstore did not rewind the
Fileobject after downloading, leading to seemingly empty crash reports. This did not cause an issue for minidumps because they are mapped asByteView.Follow-up: Use the existing download service (#1928).
Fixes #1884.