Skip to content

feat(cli): Symbolicate remote apple crash reports#1923

Merged
jjbayer merged 1 commit intomasterfrom
feat/cli-apple-crash-report-remote
Apr 13, 2026
Merged

feat(cli): Symbolicate remote apple crash reports#1923
jjbayer merged 1 commit intomasterfrom
feat/cli-apple-crash-report-remote

Conversation

@jjbayer
Copy link
Copy Markdown
Member

@jjbayer jjbayer commented Apr 13, 2026

#1900 added the ability to symbolicate apple crash reports with symbolicli in --offline mode. This PR extends the functionality to also support --online mode.

ref: #1884

@jjbayer jjbayer marked this pull request as ready for review April 13, 2026 14:24
@jjbayer jjbayer requested a review from a team as a code owner April 13, 2026 14:24
@jjbayer jjbayer merged commit 44e94c2 into master Apr 13, 2026
25 checks passed
@jjbayer jjbayer deleted the feat/cli-apple-crash-report-remote branch April 13, 2026 14:24

if &magic == b"MDMP" || &magic == b"PMDM" {
Ok(Payload::Minidump(file))
} else if &magic == b"Inci" || &magic == b"----" {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The code classifies files starting with b"----" as Apple crash reports, but the downstream parser likely doesn't support this format, which will cause a runtime crash.
Severity: HIGH

Suggested Fix

Remove the || &magic == b"----" check. Alternatively, if this format is valid, add test cases with fixtures that start with b"----" to verify the parser can handle them. Also, add documentation explaining what this format represents.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: crates/symbolicli/src/main.rs#L275

Potential issue: The code adds a check for `b"----"` to identify Apple crash reports.
When a file with these magic bytes is encountered, it's passed to
`AppleCrashReport::from_reader()`. However, there is no evidence that the
`apple_crash_report_parser` crate supports this format. This will likely cause the
parser to fail, resulting in an unhandled error that crashes the `symbolicli` tool with
the message "failed to parse apple crash report". This can be triggered in online mode
if a Sentry event has an `event.applecrashreport` attachment starting with `----`.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants