Skip to content

ref: Instrument sentry::list_files #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loewenheim merged 1 commit into from
Apr 13, 2026
+4 −1
Merged

ref: Instrument sentry::list_files #1922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/symbolicator-service/src/download/sentry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ impl SentryDownloader {
}
}

#[tracing::instrument(skip(self, source), fields(query))]
pub async fn list_files(
&self,
source: Arc<SentrySourceConfig>,
Expand All @@ -181,6 +182,8 @@ impl SentryDownloader {
.append_pair("code_id", code_id.as_str());
}

tracing::Span::current().record("query", index_url.to_string());

// NOTE: We intentionally don't limit the query to the provided file types, even though
// the endpoint supports it. The reason is that the result of the query gets cached locally
// and we can then filter the cached results. This saves us from making individual requests to Sentry
Expand Down Expand Up @@ -225,7 +228,7 @@ impl SentryDownloader {
// TODO(flub): These queries do not handle pagination. But sentry only starts to
// paginate at 20 results so we get away with this for now.
if result.len() >= 20 {
tracing::error!(query = ?query.index_url, "Sentry API Query returned 20 results");
tracing::error!("Sentry API Query returned 20 results");
}
}

Expand Down
Loading