feat(proguard): Bump proguard to 5.10.1 and filter synthesized frames#1896
Merged
feat(proguard): Bump proguard to 5.10.1 and filter synthesized frames#1896
Conversation
- Handle `StackFrame::line()` returning `Option<usize>` instead of `usize` - Filter out compiler-synthesized frames (e.g. lambda bridges) from remapped stacktraces, matching R8 retrace behavior - Only filter synthesized frames when the original frame had a line number, matching a retrace quirk where no-line-number resolution skips range-level synthesized annotations - Fix incomplete test mapping in `remap_filename_inlined` to include outline callsite position entries - Update integration test snapshots for new filename/abs_path fields Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Autofix Details
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Symbolication stats count frames later dropped by filtering
- Moved symbolicated_frames counting to after synthesized-frame filtering so only retained frames are counted.
Or push these changes by commenting:
@cursor push 07be777269
Preview (07be777269)
diff --git a/crates/symbolicator-proguard/src/symbolication.rs b/crates/symbolicator-proguard/src/symbolication.rs
--- a/crates/symbolicator-proguard/src/symbolication.rs
+++ b/crates/symbolicator-proguard/src/symbolication.rs
@@ -326,16 +326,11 @@
{
mapped_frame.in_app = Some(true);
}
-
- // Also count the frames as symbolicated at this point
- *stats
- .symbolicated_frames
- .entry(mapped_frame.platform.clone())
- .or_default() += 1;
}
}
// If all else fails, just return the original frame.
+ let was_symbolicated = mapped_result.is_some();
let mut frames = mapped_result.unwrap_or_else(|| {
*stats
.unsymbolicated_frames
@@ -365,6 +360,16 @@
}
}
+ // Count only frames that remain after filtering and were actually symbolicated
+ if was_symbolicated {
+ for mapped_frame in &frames {
+ *stats
+ .symbolicated_frames
+ .entry(mapped_frame.platform.clone())
+ .or_default() += 1;
+ }
+ }
+
remapped_frames.extend(frames);
}Filter out synthesized frames before incrementing symbolicated_frames so that dropped frames are not overcounted in the num_frames metric. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Dav1dde
approved these changes
Mar 10, 2026
romtsn
added a commit
to getsentry/rust-proguard
that referenced
this pull request
Mar 10, 2026
## Summary - When a frame has no line number and there are no base entries (endline==0), detect if the first range group forms an inline chain (multiple entries sharing the same startline/endline) and resolve each entry with its proper original line instead of emitting all entries with line 0 - This matches retrace's `allRangesForLine(0, true)` behavior, which picks the first range containing line 0 and returns all entries in that group - Applied to both `ProguardCache` and `ProguardMapper` Fixes CI in getsentry/symbolicator#1896 where the regression has been discovered ## Test plan - [ ] Existing tests pass - [ ] Verify with mapping files that contain inline groups without base entries 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Bumps proguard to 5.10.1 which contains a CI fix. Also documents the intentional line-0 fallback behavior that matches retrace's allRangesForLine(0, true) resolution path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8aa2054 to
a03ac4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
proguardcrate from 5.9.0 to 5.10.0StackFrame::line()now returningOption<usize>instead ofusizeCurrently blocked by getsentry/rust-proguard#88 which needs to be shipped in a patch release and bumped here to make the CI pass
Test plan
🤖 Generated with Claude Code