Skip to content

feat(aci): add GET DataConditions endpoint#87111

Merged
ameliahsu merged 12 commits intomasterfrom
mia/aci/data-conditions-endpoint
Mar 19, 2025
Merged

feat(aci): add GET DataConditions endpoint#87111
ameliahsu merged 12 commits intomasterfrom
mia/aci/data-conditions-endpoint

Conversation

@ameliahsu
Copy link
Copy Markdown
Contributor

@ameliahsu ameliahsu commented Mar 14, 2025

add GET DataConditions endpoint /organization/:id_or_slug/data_conditions/

must specify a group in the request to filter the results by workflow_trigger, action_filter, or detector_trigger

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 98.98990% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rc/sentry/workflow_engine/endpoints/serializers.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #87111      +/-   ##
==========================================
+ Coverage   85.34%   87.75%   +2.40%     
==========================================
  Files        9864     9869       +5     
  Lines      559041   559614     +573     
  Branches    22043    22037       -6     
==========================================
+ Hits       477123   491064   +13941     
+ Misses      81194    68119   -13075     
+ Partials      724      431     -293     

@ameliahsu ameliahsu force-pushed the mia/aci/data-conditions-endpoint branch from 0ea16df to 9839f89 Compare March 14, 2025 21:37
@ameliahsu ameliahsu marked this pull request as ready for review March 14, 2025 21:38
@ameliahsu ameliahsu requested a review from a team as a code owner March 14, 2025 21:38
Comment thread src/sentry/workflow_engine/models/data_condition.py Outdated
Comment thread tests/sentry/workflow_engine/endpoints/test_organization_data_condition_index.py Outdated
Comment thread tests/sentry/workflow_engine/endpoints/test_organization_data_condition_index.py Outdated
Comment thread src/sentry/workflow_engine/endpoints/serializers.py Outdated
Comment thread src/sentry/workflow_engine/endpoints/organization_data_condition_index.py Outdated
Comment thread src/sentry/workflow_engine/endpoints/organization_data_condition_index.py Outdated
Comment thread src/sentry/workflow_engine/endpoints/serializers.py Outdated
@ameliahsu ameliahsu marked this pull request as draft March 17, 2025 21:56
@ameliahsu ameliahsu force-pushed the mia/aci/data-conditions-endpoint branch from 1c56a1b to a7d955c Compare March 17, 2025 23:24
@ameliahsu ameliahsu changed the base branch from master to mia/dc-handlers/rename March 17, 2025 23:24
@ameliahsu ameliahsu marked this pull request as ready for review March 17, 2025 23:25
@ameliahsu ameliahsu marked this pull request as draft March 18, 2025 18:11
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 18, 2025
@ameliahsu ameliahsu force-pushed the mia/aci/data-conditions-endpoint branch from 853776b to b1042ce Compare March 18, 2025 18:12
@getsentry getsentry deleted a comment from github-actions bot Mar 18, 2025
@ameliahsu ameliahsu force-pushed the mia/aci/data-conditions-endpoint branch from b1042ce to c174d72 Compare March 18, 2025 18:15
@ameliahsu ameliahsu force-pushed the mia/dc-handlers/rename branch from 0701e49 to f5fff15 Compare March 18, 2025 18:17
@getsentry getsentry deleted a comment from github-actions bot Mar 18, 2025
@iamrajjoshi iamrajjoshi removed the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 18, 2025
@ameliahsu ameliahsu requested a review from a team March 18, 2025 18:57
Base automatically changed from mia/dc-handlers/rename to master March 18, 2025 22:09
@ameliahsu ameliahsu marked this pull request as ready for review March 18, 2025 22:13
Comment thread src/sentry/workflow_engine/endpoints/organization_data_condition_index.py Outdated
@ameliahsu ameliahsu merged commit 52c316b into master Mar 19, 2025
48 checks passed
@ameliahsu ameliahsu deleted the mia/aci/data-conditions-endpoint branch March 19, 2025 21:43
andrewshie-sentry pushed a commit that referenced this pull request Mar 27, 2025
add GET DataConditions endpoint
`/organization/:id_or_slug/data_conditions/`

must specify a `group` in the request to filter the results by
`workflow_trigger`, `action_filter`, or `detector_trigger`
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants