ref: fix 'occured' -> 'occurred' typos across sentry_apps, UI, and loader templates#113145
ref: fix 'occured' -> 'occurred' typos across sentry_apps, UI, and loader templates#113145SAY-5 wants to merge 10 commits intogetsentry:masterfrom
Conversation
Comment and f-string in src/sentry/sentry_apps/utils/errors.py (lines 54, 74) read 'occured'. Fixed to 'occurred'. String-literal-only change. Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Following the fix in errors.py, test assertions that expected "An issue occured" need updating to "occurred" so they match the new string. Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Following the fix in errors.py, test assertions that expected "An issue occured" need updating to "occurred" so they match the new string. Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Following the fix in errors.py, test assertions that expected "An issue occured" need updating to "occurred" so they match the new string. Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
1 similar comment
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
|
Note: CI failures appear to be external-PR permission gates ( |
Summary
Fix
occured→occurredtypos across Sentry. Multiple are user-visible — surfaced in API error responses, the JS SDK loader template (served to every site using the loader), and UI components.Changes
Source fixes
src/sentry/sentry_apps/utils/errors.pysrc/sentry/sentry_apps/external_requests/issue_link_requester.pymessagesrc/sentry/templates/sentry/js-sdk-loader.js.tmplsrc/sentry/templates/sentry/js-sdk-loader.tsstatic/app/views/insights/crons/types.tsxstatic/app/views/preprod/buildDetails/sidebar/buildDetailsSidebarStatusCheck.tsxstatic/gsApp/components/upgradeNowModal/modalSamePrice.tsxTest updates (following the string changes)
tests/sentry/sentry_apps/api/bases/test_sentryapps.pytests/sentry/sentry_apps/api/endpoints/test_sentry_app_installation_external_issue_actions.pytests/sentry/sentry_apps/api/endpoints/test_sentry_app_installation_external_issues.pyAll assertions against the old string updated to match. Tests stay green.
Testing
String-replacement change. Existing test suite (updated assertions) verifies the new strings.