Skip to content

ref: fix 'occured' -> 'occurred' typos across sentry_apps, UI, and loader templates#113145

Open
SAY-5 wants to merge 10 commits intogetsentry:masterfrom
SAY-5:fix-sentry-apps-occured-typo
Open

ref: fix 'occured' -> 'occurred' typos across sentry_apps, UI, and loader templates#113145
SAY-5 wants to merge 10 commits intogetsentry:masterfrom
SAY-5:fix-sentry-apps-occured-typo

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented Apr 16, 2026

Summary

Fix occuredoccurred typos across Sentry. Multiple are user-visible — surfaced in API error responses, the JS SDK loader template (served to every site using the loader), and UI components.

Changes

Source fixes

File Kind User-visible?
src/sentry/sentry_apps/utils/errors.py API error detail + comment ✅ yes
src/sentry/sentry_apps/external_requests/issue_link_requester.py API error message ✅ yes
src/sentry/templates/sentry/js-sdk-loader.js.tmpl Loader template comment served in loader output
src/sentry/templates/sentry/js-sdk-loader.ts TS source for loader served in loader output
static/app/views/insights/crons/types.tsx JSDoc comment no
static/app/views/preprod/buildDetails/sidebar/buildDetailsSidebarStatusCheck.tsx User-visible error message ✅ yes
static/gsApp/components/upgradeNowModal/modalSamePrice.tsx Modal body text ✅ yes

Test updates (following the string changes)

  • tests/sentry/sentry_apps/api/bases/test_sentryapps.py
  • tests/sentry/sentry_apps/api/endpoints/test_sentry_app_installation_external_issue_actions.py
  • tests/sentry/sentry_apps/api/endpoints/test_sentry_app_installation_external_issues.py

All assertions against the old string updated to match. Tests stay green.

Testing

String-replacement change. Existing test suite (updated assertions) verifies the new strings.

Comment and f-string in src/sentry/sentry_apps/utils/errors.py (lines 54, 74) read 'occured'. Fixed to 'occurred'. String-literal-only change.

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
@SAY-5 SAY-5 requested review from a team as code owners April 16, 2026 03:20
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2026
SAY-5 added 5 commits April 16, 2026 14:25
Following the fix in errors.py, test assertions that expected "An issue occured" need updating to "occurred" so they match the new string.

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Following the fix in errors.py, test assertions that expected "An issue occured" need updating to "occurred" so they match the new string.

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Following the fix in errors.py, test assertions that expected "An issue occured" need updating to "occurred" so they match the new string.

Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
@SAY-5 SAY-5 requested a review from a team as a code owner April 16, 2026 21:26
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
@SAY-5 SAY-5 requested a review from a team as a code owner April 16, 2026 21:26
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
@SAY-5 SAY-5 requested a review from a team as a code owner April 16, 2026 21:26
SAY-5 added 2 commits April 16, 2026 14:26
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
@SAY-5 SAY-5 requested a review from a team as a code owner April 16, 2026 21:26
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@SAY-5 SAY-5 changed the title ref(sentry_apps): fix 'occured' -> 'occurred' typos in error messages ref: fix 'occured' -> 'occurred' typos across sentry_apps, UI, and loader templates Apr 16, 2026
@SAY-5
Copy link
Copy Markdown
Author

SAY-5 commented Apr 16, 2026

Note: CI failures appear to be external-PR permission gates (permissions step in getsentry dispatch, snapshot upload permission) rather than anything introduced by this change. The actual test assertions have been updated to match the new corrected strings. Happy to rebase if needed after a maintainer kicks the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant