fix(onboarding): Harden SCM project creation against duplicates#113111
Draft
jaydgoss wants to merge 1 commit intojaygoss/ref-onboarding-context-persist-form-statefrom
Draft
fix(onboarding): Harden SCM project creation against duplicates#113111jaydgoss wants to merge 1 commit intojaygoss/ref-onboarding-context-persist-form-statefrom
jaydgoss wants to merge 1 commit intojaygoss/ref-onboarding-context-persist-form-statefrom
Conversation
github-actions
bot
added
the
Scope: Frontend
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
397f062 to
d3a87b1
Compare
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
d3a87b1 to
a4e6b6a
Compare
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
a4e6b6a to
444985a
Compare
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
444985a to
5b45390
Compare
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
c67bae3 to
d453e09
Compare
jaydgoss
changed the base branch from
master
to
jaygoss/ref-onboarding-context-persist-form-state
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
d453e09 to
6579666
Compare
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
6579666 to
8d87891
Compare
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
8d87891 to
3529183
Compare
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
3529183 to
b349eb1
Compare
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
b349eb1 to
07d66a1
Compare
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
07d66a1 to
0c9ada8
Compare
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
0c9ada8 to
1620994
Compare
jaydgoss
force-pushed
the
jaygoss/ref-onboarding-context-persist-form-state
branch
from
f1ef345 to
63dffeb
Compare
When the user navigates back from setup-docs after the project has already received events, the project is not deleted. Handle this by detecting the existing project via createdProjectSlug and persisted form state: - Platform changed: abandon old project, create new (matching legacy) - No changes: reuse existing project as-is - Name/team changed: update existing project in place via PUT Also guard the Create button against teams and projects still loading so the existence check cannot be bypassed by a race.
jaydgoss
force-pushed
the
jaygoss/fix-scm-onboarding-project-gaps
branch
from
1620994 to
c5646a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the case where a user navigates back from setup-docs after the project
has already received events (so it was not deleted by useBackActions). Uses
persisted form state from the onboarding context for the read side, and a
simple existence check via the projects store as a safety net.
Also guard the Create button against teams and projects still loading so the
existence check cannot be bypassed by a race.
PR stack: