Skip to content

Display name validation and filtering for apps and orgs#113106

Open
geoffg-sentry wants to merge 5 commits intomasterfrom
geoffg-sentry/display-name-app-name-filtering
Open

Display name validation and filtering for apps and orgs#113106
geoffg-sentry wants to merge 5 commits intomasterfrom
geoffg-sentry/display-name-app-name-filtering

Conversation

@geoffg-sentry
Copy link
Copy Markdown
Contributor

@geoffg-sentry geoffg-sentry commented Apr 15, 2026

Adds some display name validation and filtering for org and app names during org creation and edits. Reduces abuse potential, a follow up from #113052

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 15, 2026
@geoffg-sentry geoffg-sentry changed the title Geoffg sentry/display name app name filtering Display name validation and filtering for apps and orgs Apr 15, 2026
@geoffg-sentry geoffg-sentry marked this pull request as ready for review April 15, 2026 20:21
@geoffg-sentry geoffg-sentry requested review from a team as code owners April 15, 2026 20:21
Comment thread src/sentry/utils/display_name_filter.py
Comment thread src/sentry/utils/display_name_filter.py
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9c70b12. Configure here.

Comment thread src/sentry/utils/display_name_filter.py Outdated
Comment thread src/sentry/utils/display_name_filter.py
Comment thread src/sentry/api/serializers/models/organization.py Outdated
Comment thread src/sentry/utils/display_name_filter.py Outdated
Copy link
Copy Markdown
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There is one other place where we handle organization names during account creation in getsentry (getsentry/api/signup_with_trial.py) that isn't using the organization serializer to do validation. I think we'd need to patch that implementation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants