ref(project-detail): Use relative period params for previous period queries#113100
Merged
ref(project-detail): Use relative period params for previous period queries#113100
Conversation
…ueries Replace absolute start/end date computation via parseStatsPeriod with relative statsPeriodStart/statsPeriodEnd params in the velocity and ANR score cards, matching the pattern already used by the stability card. This also removes a stray console.log from the velocity card and an unused parseStatsPeriod import from the apdex card. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
…d params Update mock matchers and assertions to expect statsPeriodStart/statsPeriodEnd instead of absolute start/end dates, matching the implementation change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nsdeschenes
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the cards on the Project Details pages cause re-fetch cascades:
The loop is:
Loop forever. There are a few possible solutions here, including memoizing the component. Instead, I thought it would be simpler to use the same approach that some of the other card are using, which is the
statsPeriodStartandstatsPeriodEndquery parameters. Instead of a timestamp, they specify the start and end as strings, so e.g.,28dto14dto fetch the previous period. This creates a stable query key for Tan Stack Query, and stops the refetch. We also could have, for example, dropped down to a bigger precision (instead of using seconds), but this seems the tidiest to me.This is an alternative to #113087
I'm not sure why those other cards didn't use
statsPeriodStart, maybe it wasn't available at the time, or the engineer didn't know about it?