Skip to content

fix(insights): Fix empty txn summary when transaction.op is default #113099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjq merged 1 commit into from
Apr 15, 2026
+12 −4
Merged

fix(insights): Fix empty txn summary when transaction.op is default #113099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions static/app/views/dashboards/datasetConfig/spans.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,12 +474,14 @@ function renderTransactionAsLinkable(data: EventData, baggage: RenderFunctionBag

const filters = new MutableSearch('');

// Filters on the transaction summary page won't match the dashboard because transaction summary isn't on eap yet.
const isEap = organization.features.includes('performance-transaction-summary-eap');
if (data[SpanFields.SPAN_OP]) {
filters.addFilterValue('transaction.op', data[SpanFields.SPAN_OP]);
filters.addFilterValue(
isEap ? SpanFields.SPAN_OP : SpanFields.TRANSACTION_OP,
data[SpanFields.SPAN_OP]
);
}
if (data[SpanFields.REQUEST_METHOD]) {
const isEap = organization.features.includes('performance-transaction-summary-eap');
filters.addFilterValue(
isEap ? 'request.method' : 'http.method',
data[SpanFields.REQUEST_METHOD]
Expand Down
8 changes: 7 additions & 1 deletion static/app/views/insights/pages/transactionCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import {useOrganization} from 'sentry/utils/useOrganization';
import {useProjects} from 'sentry/utils/useProjects';
import {OverflowEllipsisTextContainer} from 'sentry/views/insights/common/components/textAlign';
import {useDomainViewFilters} from 'sentry/views/insights/pages/useFilters';
import {SpanFields} from 'sentry/views/insights/types';
import {useTransactionSummaryEAP} from 'sentry/views/performance/eap/useTransactionSummaryEAP';
import {generateTransactionSummaryRoute} from 'sentry/views/performance/transactionSummary/utils';

interface Props {
Expand All @@ -21,12 +23,16 @@ export function TransactionCell({project, transaction, transactionMethod}: Props
const organization = useOrganization();
const location = useLocation();
const {view} = useDomainViewFilters();
const isEAP = useTransactionSummaryEAP();

const projectId = projects.projects.find(p => p.slug === project)?.id;

const searchQuery = new MutableSearch('');
if (transactionMethod) {
searchQuery.addFilterValue('transaction.op', transactionMethod);
searchQuery.addFilterValue(
isEAP ? SpanFields.SPAN_OP : SpanFields.TRANSACTION_OP,
transactionMethod
);
}

if (!transaction || !projectId) {
Expand Down
Loading