Skip to content

ref(nav): extract header actions, use pageframe slots#113083

Merged
natemoo-re merged 6 commits intomasterfrom
nm/nav/issue-detail-actions
Apr 15, 2026
Merged

ref(nav): extract header actions, use pageframe slots#113083
natemoo-re merged 6 commits intomasterfrom
nm/nav/issue-detail-actions

Conversation

@natemoo-re
Copy link
Copy Markdown
Member

Refactors the Issue Details header actions:

  • extracts actions into a self-contained component
  • switch control flow to if-return over inline ternaries
  • introduces a MaybeTopBarSlot component that does slot projection behind the page-frame flag
Before After
issue-detail-before issue-detail-after

Closes DE-1134

@natemoo-re natemoo-re requested a review from a team as a code owner April 15, 2026 18:25
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 15, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 15, 2026
@natemoo-re natemoo-re requested a review from a team April 15, 2026 18:27
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9dc5ee5. Configure here.

Comment thread static/app/views/issueDetails/streamline/header/header.tsx Outdated
Comment thread static/app/views/issueDetails/streamline/header/header.tsx
Comment thread static/app/views/issueDetails/streamline/header/header.tsx Outdated
Copy link
Copy Markdown
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it makes things easier, we can drop the NewIssueExperienceButton completely

We wanted to keep it in for a little bit after forcing the new experience on everyone, but it has been long enough now that we can just delete it (from the current experience and the new page frame one)

@natemoo-re natemoo-re enabled auto-merge (squash) April 15, 2026 20:05
@natemoo-re natemoo-re merged commit 998580f into master Apr 15, 2026
64 checks passed
@natemoo-re natemoo-re deleted the nm/nav/issue-detail-actions branch April 15, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants