feat(onboarding): Gate SCM_PROJECT_DETAILS step with feature flag#113069
Closed
feat(onboarding): Gate SCM_PROJECT_DETAILS step with feature flag#113069
Conversation
When `onboarding-scm-project-details` flag is absent, skip the project details step and auto-create the project with defaults (platform key as name, first admin team, default alert rules) during the platform features Continue action. Refs VDY-82
github-actions
bot
added
the
Scope: Frontend
The back action checked for prevStep.id === 'scm-project-details' to decide whether to preserve onboarding state. When that step is skipped, the previous step is scm-platform-features, so the check failed and the entire session was wiped. Broaden the check to any SCM step. Refs VDY-82
jaydgoss
force-pushed
the
jaygoss/vdy-82-experiment-gate-scm_project_details-step-within-scm
branch
from
5b65310 to
1e517d0
Compare
When a user goes back from setup-docs after the project has already received its first event, the project is not deleted. Without this guard, clicking Continue/Create again would attempt to create a duplicate. Check the projects store first and reuse the existing project, mirroring the useConfigureSdk logic. Also use useExperiment for the SCM back-action check to stay consistent with how onboarding.tsx reads the experiment flag. Refs VDY-82
Member
Author
|
Splitting into a stacked PR pair — gap fixes in PR 1, VDY-82 feature flag gating in PR 2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate the
SCM_PROJECT_DETAILSstep behind theonboarding-scm-project-detailsfeature flag to experiment with a shorter SCM onboarding flow.When the flag is present, the flow is unchanged:
SCM_CONNECT -> SCM_PLATFORM_FEATURES -> SCM_PROJECT_DETAILS -> SETUP_DOCSWhen the flag is absent, the project details step is skipped:
SCM_CONNECT -> SCM_PLATFORM_FEATURES -> SETUP_DOCSIn the skipped case, clicking Continue on the platform features step auto-creates the project with defaults (platform key as name, first admin team, default alert rules), sets
createdProjectSlugin context soSETUP_DOCScan find it, and passes selected features as query products. The Continue button shows a loading state during creation and surfaces an error toast if it fails.The flag is not yet registered in
temporary.py-- this is the client-side wiring only. What is lost when the step is skipped: custom project name, team selection, alert frequency configuration (all fall back to defaults matching the legacy onboarding flow).Refs VDY-82