fix(autofix): Ignore default-valued options when checking if preference is configured#113064
Closed
fix(autofix): Ignore default-valued options when checking if preference is configured#113064
Conversation
… check Projects with autofix_automation_tuning explicitly set to its default (OFF) — e.g. by set_default_project_autofix_automation_tuning at project creation — were incorrectly treated as having configured preferences. This caused read_preference_from_sentry_db to return a SeerProjectPreference with empty repositories instead of None, skipping the fallback path that populates repos from code mappings. Compare option values against their registered defaults so only meaningfully configured options count. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects with
autofix_automation_tuningexplicitly set to its default ("OFF") — e.g. byset_default_project_autofix_automation_tuningat project creation — were being treated as having configured preferences. This causedread_preference_from_sentry_dbto return aSeerProjectPreferencewith empty repositories instead ofNone, skipping the fallback path that populates repos from code mappings intrigger_autofix.Compare option values against their registered defaults so only meaningfully configured options count.