Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 33 additions & 53 deletions static/app/actionCreators/projects.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {useCallback} from 'react';
import {queryOptions, skipToken, useQueryClient} from '@tanstack/react-query';
import type {Query} from 'history';
import chunk from 'lodash/chunk';
import debounce from 'lodash/debounce';
Expand All @@ -14,9 +14,7 @@ import {ProjectsStatsStore} from 'sentry/stores/projectsStatsStore';
import {ProjectsStore} from 'sentry/stores/projectsStore';
import type {Team} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
import {getApiUrl} from 'sentry/utils/api/getApiUrl';
import type {ApiQueryKey} from 'sentry/utils/queryClient';
import {setApiQueryData, useApiQuery, useQueryClient} from 'sentry/utils/queryClient';
import {apiOptions} from 'sentry/utils/api/apiOptions';
import {useApi} from 'sentry/utils/useApi';

type UpdateParams = {
Expand Down Expand Up @@ -284,27 +282,7 @@ export function fetchProjectsCount(api: Client, orgSlug: string) {
return api.requestPromise(`/organizations/${orgSlug}/projects-count/`);
}

function makeProjectTeamsQueryKey({
orgSlug,
projectSlug,
cursor,
}: {
orgSlug: string;
projectSlug: string;
cursor?: string;
}): ApiQueryKey {
return [
getApiUrl('/projects/$organizationIdOrSlug/$projectIdOrSlug/teams/', {
path: {
organizationIdOrSlug: orgSlug,
projectIdOrSlug: projectSlug,
},
}),
{query: {cursor}},
];
}

export function useFetchProjectTeams({
export function projectTeamsApiOptions({
orgSlug,
projectSlug,
cursor,
Expand All @@ -313,10 +291,19 @@ export function useFetchProjectTeams({
projectSlug: string;
cursor?: string;
}) {
return useApiQuery<Team[]>(makeProjectTeamsQueryKey({orgSlug, projectSlug, cursor}), {
staleTime: 0,
return queryOptions({
...apiOptions.as<Team[]>()(
'/projects/$organizationIdOrSlug/$projectIdOrSlug/teams/',
{
path:
orgSlug && projectSlug
? {organizationIdOrSlug: orgSlug, projectIdOrSlug: projectSlug}
: skipToken,
query: {cursor},
staleTime: 0,
}
),
retry: false,
enabled: Boolean(orgSlug && projectSlug),
});
}

Expand All @@ -331,19 +318,15 @@ export function useAddTeamToProject({
}) {
const api = useApi();
const queryClient = useQueryClient();
const {queryKey} = projectTeamsApiOptions({orgSlug, projectSlug, cursor});

return useCallback(
async (team: Team) => {
await addTeamToProject(api, orgSlug, projectSlug, team);

setApiQueryData<Team[]>(
queryClient,
makeProjectTeamsQueryKey({orgSlug, projectSlug, cursor}),
prevData => (Array.isArray(prevData) ? [team, ...prevData] : [team])
);
},
[api, orgSlug, projectSlug, cursor, queryClient]
);
return async (team: Team) => {
await addTeamToProject(api, orgSlug, projectSlug, team);

queryClient.setQueryData(queryKey, prevData =>
prevData ? {...prevData, json: [team, ...prevData.json]} : prevData
);
};
}

export function useRemoveTeamFromProject({
Expand All @@ -357,18 +340,15 @@ export function useRemoveTeamFromProject({
}) {
const api = useApi();
const queryClient = useQueryClient();
const {queryKey} = projectTeamsApiOptions({orgSlug, projectSlug, cursor});

return async (teamSlug: string) => {
await removeTeamFromProject(api, orgSlug, projectSlug, teamSlug);

return useCallback(
async (teamSlug: string) => {
await removeTeamFromProject(api, orgSlug, projectSlug, teamSlug);

setApiQueryData<Team[]>(
queryClient,
makeProjectTeamsQueryKey({orgSlug, projectSlug, cursor}),
prevData =>
Array.isArray(prevData) ? prevData.filter(team => team?.slug !== teamSlug) : []
);
},
[api, orgSlug, projectSlug, cursor, queryClient]
);
queryClient.setQueryData(queryKey, prevData =>
prevData
? {...prevData, json: prevData.json.filter(team => team?.slug !== teamSlug)}
: prevData
);
};
}
24 changes: 13 additions & 11 deletions static/app/views/settings/project/projectTeams.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import {useQuery} from '@tanstack/react-query';

import {addErrorMessage} from 'sentry/actionCreators/indicator';
import {
projectTeamsApiOptions,
useAddTeamToProject,
useFetchProjectTeams,
useRemoveTeamFromProject,
} from 'sentry/actionCreators/projects';
import {hasEveryAccess} from 'sentry/components/acl/access';
Expand All @@ -12,6 +14,7 @@ import {Pagination} from 'sentry/components/pagination';
import {SentryDocumentTitle} from 'sentry/components/sentryDocumentTitle';
import {t, tct} from 'sentry/locale';
import {TeamStore} from 'sentry/stores/teamStore';
import {selectJsonWithHeaders} from 'sentry/utils/api/apiOptions';
import {decodeScalar} from 'sentry/utils/queryString';
import {routeTitleGen} from 'sentry/utils/routeTitle';
import {useLocation} from 'sentry/utils/useLocation';
Expand All @@ -29,16 +32,15 @@ export default function ProjectTeams() {
const organization = useOrganization();
const {project} = useProjectSettingsOutlet();

const {
data: projectTeams,
isPending,
isError,
getResponseHeader,
} = useFetchProjectTeams({
orgSlug: organization.slug,
projectSlug: project.slug,
cursor: decodeScalar(location.query.cursor),
const {data, isPending, isError} = useQuery({
...projectTeamsApiOptions({
orgSlug: organization.slug,
projectSlug: project.slug,
cursor: decodeScalar(location.query.cursor),
}),
select: selectJsonWithHeaders,
});
const projectTeams = data?.json;

const handleAddTeamToProject = useAddTeamToProject({
orgSlug: organization.slug,
Expand Down Expand Up @@ -107,7 +109,7 @@ export default function ProjectTeams() {
onRemoveTeam={handleRemoveTeamFromProject}
onCreateTeam={handleAddTeamToProject}
/>
<Pagination pageLinks={getResponseHeader?.('Link')} onCursor={handleCursor} />
<Pagination pageLinks={data?.headers.Link} onCursor={handleCursor} />
</div>
</SentryDocumentTitle>
);
Expand Down
Loading