ref(integrations): Refactor useAddIntegration to accept params at call time#113059
Merged
evanpurkhiser merged 1 commit intomasterfrom Apr 15, 2026
Conversation
github-actions
bot
added
the
Scope: Frontend
Contributor
Sentry Snapshot Testing
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2a89eca. Configure here.
…l time Move useAddIntegration from views/settings/organizationIntegrations/ to utils/integrations/ and change the API so startFlow() accepts all params (provider, organization, onInstall, etc.) at call time instead of at hook init. The hook now manages its own message listener via refs, so a single instance can launch flows for any provider without a context provider. This enables multi-provider UIs like dropdowns to share one hook above the dropdown, passing the selected provider to startFlow on click. Extract computeCenteredWindow to utils/window/ and add urlParams to AddIntegrationParams for the installation_id case. Refs VDY-69
jaydgoss
approved these changes
Apr 15, 2026
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-integrations-refactor-useaddintegration-to-accept-params-at-call-time
branch
from
2a89eca to
2499e12
Compare
evanpurkhiser
deleted the
evanpurkhiser/ref-integrations-refactor-useaddintegration-to-accept-params-at-call-time
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move useAddIntegration from views/settings/organizationIntegrations/ to
utils/integrations/ and change the API so startFlow() accepts all params
(provider, organization, onInstall, etc.) at call time instead of at
hook init. The hook now manages its own message listener via refs, so a
single instance can launch flows for any provider without a context
provider.
This enables multi-provider UIs like dropdowns to share one hook above
the dropdown, passing the selected provider to startFlow on click.
Extract computeCenteredWindow to utils/window/ and add urlParams to
AddIntegrationParams for the installation_id case.
Refs VDY-69