Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/components/banner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const BannerWrapper = styled('div')<BannerWrapperProps>`
justify-content: center;
position: relative;
margin-bottom: ${p => p.theme.space.xl};
box-shadow: ${p => p.theme.dropShadowMedium};
box-shadow: ${p => p.theme.shadow.medium};
border-radius: ${p => p.theme.radius.md};
height: 180px;
color: ${p => p.theme.colors.white};
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/charts/components/tooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ export function computeChartTooltip(
trigger: 'item',
backgroundColor: theme.tokens.background.primary,
borderWidth: 0,
extraCssText: `box-shadow: 0 0 0 1px ${theme.tokens.border.transparent.neutral.muted}, ${theme.dropShadowHeavy}`,
extraCssText: `box-shadow: 0 0 0 1px ${theme.tokens.border.transparent.neutral.muted}, ${theme.shadow.high}`,
transitionDuration: 0,
padding: 0,
className: 'tooltip-container',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ const _SlideOverPanel = styled(motion.div, {

z-index: ${p => p.theme.zIndex.modal - 1};

background: ${p => p.theme.tokens.background.primary};
background: ${p => p.theme.tokens.background.overlay};
box-shadow: ${p => p.theme.shadow.high};
color: ${p => p.theme.tokens.content.primary};

text-align: left;
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/events/autofix/autofixChanges.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ const PrefixText = styled('span')``;
const ChangesContainer = styled('div')`
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowMedium};
box-shadow: ${p => p.theme.shadow.medium};
padding: ${p => p.theme.space.xl};
background: ${p => p.theme.tokens.background.primary};
`;
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/events/autofix/autofixDiff.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,7 @@ const EditOverlay = styled('div')`
background: ${p => p.theme.tokens.background.primary};
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowHeavy};
box-shadow: ${p => p.theme.shadow.high};
z-index: ${p => p.theme.zIndex.tooltip};
display: flex;
flex-direction: column;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ const Container = styled(motion.div, {
border-radius: ${p => p.theme.radius.md};
border: 1px dashed ${p => p.theme.tokens.border.primary};
overflow: hidden;
box-shadow: ${p => (p.isFocused ? p.theme.dropShadowHeavy : p.theme.dropShadowLight)};
box-shadow: ${p => (p.isFocused ? p.theme.shadow.high : p.theme.shadow.low)};
transition: box-shadow 200ms ease;

&:before {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ const CausesContainer = styled('div')`
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
overflow: hidden;
box-shadow: ${p => p.theme.dropShadowMedium};
box-shadow: ${p => p.theme.shadow.medium};
padding: ${p => p.theme.space.lg};
background: ${p => p.theme.tokens.background.primary};
`;
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/events/autofix/autofixSolution.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ const SolutionContainer = styled('div')`
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
overflow: hidden;
box-shadow: ${p => p.theme.dropShadowMedium};
box-shadow: ${p => p.theme.shadow.medium};
padding: ${p => p.theme.space.lg};
background: ${p => p.theme.tokens.background.primary};
`;
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/events/autofix/codingAgentCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ const StyledCard = styled('div')`
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
overflow: hidden;
box-shadow: ${p => p.theme.dropShadowMedium};
box-shadow: ${p => p.theme.shadow.medium};
padding-left: ${p => p.theme.space.xl};
padding-right: ${p => p.theme.space.xl};
background: ${p => p.theme.tokens.background.primary};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ const InsightContainer = styled('div')<{expanded?: boolean}>`
border: 1px dashed ${p => p.theme.tokens.border.primary};
border-color: ${p => (p.expanded ? p.theme.tokens.border.primary : 'transparent')};

box-shadow: ${p => (p.expanded ? p.theme.dropShadowMedium : 'none')};
box-shadow: ${p => (p.expanded ? p.theme.shadow.medium : 'none')};
`;

const MiniHeader = styled('p')<{expanded?: boolean}>`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ const InsightsCardContainer = styled('div')`
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
overflow: hidden;
box-shadow: ${p => p.theme.dropShadowMedium};
box-shadow: ${p => p.theme.shadow.medium};
padding: ${p => p.theme.space.lg};
background: ${p => p.theme.tokens.background.primary};
width: 100%;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ const ThoughtsOverlay = styled('div')`
background: ${p => p.theme.tokens.background.primary};
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowHeavy};
box-shadow: ${p => p.theme.shadow.high};
z-index: ${p => p.theme.zIndex.tooltip};
display: flex;
flex-direction: column;
Expand Down
1 change: 0 additions & 1 deletion static/app/components/globalDrawer/components.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ const DrawerContainer = styled('div')`
`;

const DrawerSlidePanel = styled(SlideOverPanel)`
box-shadow: 0 0 0 1px ${p => p.theme.dropShadowHeavy};
border-left: 1px solid ${p => p.theme.tokens.border.primary};
position: relative;
pointer-events: auto;
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/group/groupSummaryWithAutofix.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ const InsightCardButton = styled(motion.div)`
overflow: hidden;
cursor: pointer;
padding: 0;
box-shadow: ${p => p.theme.dropShadowLight};
box-shadow: ${p => p.theme.shadow.low};
background-color: ${p => p.theme.tokens.background.primary};

&:hover {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ const OpenInDiscoverButton = styled(Button)`

const Container = styled('div')`
border: 1px solid ${p => p.theme.tokens.border.primary};
box-shadow: inset ${p => p.theme.dropShadowMedium};
box-shadow: inset ${p => p.theme.shadow.medium};
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inset keyword only applies to first shadow value

Medium Severity

box-shadow: inset ${theme.shadow.medium} prepends inset to a multi-value shadow token. Since shadow.medium expands to two comma-separated shadows, the inset keyword only applies to the first one. The second shadow renders as an external (outset) drop shadow, which differs from the original single inset dropShadowMedium behavior.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 26c4ba8. Configure here.

background: ${p => p.theme.tokens.background.secondary};
padding: 7px ${p => p.theme.space.md};
position: relative;
Expand Down
6 changes: 4 additions & 2 deletions static/app/components/overlay.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,13 @@ const OverlayInner = styled(motion.div)<{
placement?: OverlayProps['placement'];
}>`
position: relative;
background: ${p => p.theme.tokens.background.primary};
background: ${p => p.theme.tokens.background.overlay};
border-radius: ${p => p.theme.radius.md};
border: 1px solid ${p => p.theme.tokens.border.primary};
/* eslint-disable-next-line @sentry/scraps/use-semantic-token */
box-shadow: 0 2px 0 ${p => p.theme.tokens.border.primary};
box-shadow:
0 2px 0 ${p => p.theme.tokens.border.primary},
${p => p.theme.shadow.medium};
font-size: ${p => p.theme.font.size.md};

/* Override z-index from useOverlayPosition */
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/pill.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ const StyledPill = styled('li')<{type?: PillType}>`
margin: 0 ${p => p.theme.space.md} ${p => p.theme.space.md} 0;
display: flex;
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowLight};
box-shadow: ${p => p.theme.shadow.low};
line-height: 1.2;
max-width: 100%;
:last-child {
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/profiling/profilingContextMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const Menu = styled(({ref, ...props}: MenuProps) => {
background: ${p => p.theme.tokens.background.primary};
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowHeavy};
box-shadow: ${p => p.theme.shadow.high};
width: auto;
min-width: 164px;
overflow: auto;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,6 @@ const IconNode = styled('button')<{
border-radius: 50%;
color: ${p => p.theme.colors.white};
${getBackgroundGradient}
box-shadow: ${p => p.theme.dropShadowLight};
box-shadow: ${p => p.theme.shadow.low};
user-select: none;
`;
2 changes: 1 addition & 1 deletion static/app/components/replays/replayView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ const Panel = styled(FluidHeight)`
background: ${p => p.theme.tokens.background.primary};
border-radius: ${p => p.theme.radius.md};
border: 1px solid ${p => p.theme.tokens.border.primary};
box-shadow: ${p => p.theme.dropShadowMedium};
box-shadow: ${p => p.theme.shadow.medium};
`;

const ContextContainer = styled('div')`
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/search/list.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const DropdownBox = styled('div')`
background: ${p => p.theme.tokens.background.primary};
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowHeavy};
box-shadow: ${p => p.theme.shadow.high};
position: absolute;
top: 36px;
right: 0;
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/workflowEngine/ui/footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const StickyFooterBase = styled('div')`
z-index: ${p => p.theme.zIndex.initial};

&[data-stuck] {
box-shadow: ${p => p.theme.dropShadowHeavyTop};
box-shadow: ${p => p.theme.shadow.high};
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footer shadow direction changed from upward to downward

Medium Severity

The old dropShadowHeavyTop had a negative Y offset (0 -4px 24px ...) casting the shadow upward, which is correct for bottom-positioned sticky/fixed footers. The replacement theme.shadow.high has a positive Y offset (0px 4px 0px 2px ...) casting the shadow downward. For elements pinned to the bottom of the viewport, a downward shadow is invisible and loses the visual separation cue with the content above.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 26c4ba8. Configure here.

}
`;

Expand Down
2 changes: 1 addition & 1 deletion static/app/gettingStartedDocs/playstation/onboarding.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -289,5 +289,5 @@ const CardIllustration = styled('img')`
object-fit: contain;
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowLight};
box-shadow: ${p => p.theme.shadow.low};
`;
18 changes: 0 additions & 18 deletions static/app/utils/theme/theme.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -835,28 +835,11 @@ const darkColors: Colors = {
},
};

// @TODO(jonasbadalic): are these final?
const lightShadows = {
dropShadowLight: '0 0 1px rgba(43, 34, 51, 0.04)',
dropShadowMedium: '0 1px 2px rgba(43, 34, 51, 0.04)',
dropShadowHeavy: '0 4px 24px rgba(43, 34, 51, 0.12)',
dropShadowHeavyTop: '0 -4px 24px rgba(43, 34, 51, 0.12)',
};

// @TODO(jonasbadalic): are these final?
const darkShadows = {
dropShadowLight: '0 0 1px rgba(10, 8, 12, 0.2)',
dropShadowMedium: '0 1px 2px rgba(10, 8, 12, 0.2)',
dropShadowHeavy: '0 4px 24px rgba(10, 8, 12, 0.36)',
dropShadowHeavyTop: '0 -4px 24px rgba(10, 8, 12, 0.36)',
};

const lightThemeDefinition = {
type: 'light' as 'light' | 'dark',
// @TODO: color theme contains some colors (like chart color palette, diff, tag and level)
...commonTheme,
...baseLightTheme,
...lightShadows,
focusRing: (baseShadow = `0 0 0 0 ${baseLightTheme.tokens.background.primary}`) => ({
outline: 'none',
boxShadow: `${baseShadow}, 0 0 0 2px ${baseLightTheme.tokens.focus.default}`,
Expand Down Expand Up @@ -896,7 +879,6 @@ export const darkTheme: SentryTheme = {
// @TODO: color theme contains some colors (like chart color palette, diff, tag and level)
...commonTheme,
...baseDarkTheme,
...darkShadows,
focusRing: (baseShadow = `0 0 0 0 ${baseDarkTheme.tokens.background.primary}`) => ({
outline: 'none',
boxShadow: `${baseShadow}, 0 0 0 2px ${baseDarkTheme.tokens.focus.default}`,
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/admin/installWizard/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ const Version = styled('small')`
const SetupWizard = styled('div')`
background: ${p => p.theme.tokens.background.primary};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowHeavy};
box-shadow: ${p => p.theme.shadow.high};
padding: 40px 40px 20px;
max-width: 1000px;
margin: ${p => p.theme.space['2xl']};
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/discover/table/arithmeticInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ const DropdownContainer = styled('div')<{isOpen: boolean}>`
right: -1px;
z-index: ${p => p.theme.zIndex.dropdown};
background: ${p => p.theme.tokens.background.primary};
box-shadow: ${p => p.theme.dropShadowHeavy};
box-shadow: ${p => p.theme.shadow.high};
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
margin-top: ${p => p.theme.space.md};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ const IconNode = styled('div')`
height: 8px;
border-radius: 50%;
color: ${p => p.theme.colors.white};
box-shadow: ${p => p.theme.dropShadowLight};
box-shadow: ${p => p.theme.shadow.low};
user-select: none;
background-color: ${p => color(p.theme.colors.red200).alpha(0.3).string()};
margin-left: -8px;
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/onboarding/components/genericFooter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ export const GenericFooter = styled((props: React.ComponentProps<typeof motion.d
display: flex;
background-color: ${p => p.theme.tokens.background.primary};
justify-content: space-between;
box-shadow: ${p => p.theme.dropShadowHeavyTop};
box-shadow: ${p => p.theme.shadow.high};
`;
2 changes: 1 addition & 1 deletion static/app/views/performance/newTraceDetails/trace.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1483,7 +1483,7 @@ const TraceStylingWrapper = styled('div')`
line-height: 0;
z-index: 1;
font-size: 10px;
box-shadow: ${p => p.theme.dropShadowLight};
box-shadow: ${p => p.theme.shadow.low};
margin-right: 8px;

.TraceChildrenCountContent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ const MoreDropdown = styled('div')`
background: ${p => p.theme.tokens.background.primary};
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowHeavy};
box-shadow: ${p => p.theme.shadow.high};
padding: ${p => p.theme.space.xs};
display: flex;
flex-direction: column;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const TreemapControlButton = styled(Button)<{$active?: boolean}>`
padding: 0 ${p => p.theme.space.xs};
background: ${p => (p.$active ? p.theme.colors.blue400 : 'rgba(0, 0, 0, 0.8)')};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowMedium};
box-shadow: ${p => p.theme.shadow.medium};

&:hover {
color: ${p => p.theme.colors.white};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ const ColorPickerDropdown = styled('div')`
background: ${p => p.theme.tokens.background.primary};
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowHeavy};
box-shadow: ${p => p.theme.shadow.high};
z-index: ${p => p.theme.zIndex.dropdown};
`;

Expand Down
2 changes: 1 addition & 1 deletion static/app/views/seerExplorer/explorerMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ const MenuPanel = styled('div')<{
background: ${p => p.theme.tokens.background.primary};
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowHeavy};
box-shadow: ${p => p.theme.shadow.high};
max-height: ${p =>
p.panelSize === 'max' ? 'calc(100vh - 120px)' : 'calc(50vh - 80px)'};
overflow-y: auto;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ const SourceGroupContainer = styled('div')<{isExpanded?: boolean}>`
css`
border-radius: ${p.theme.radius.md};
border: 1px solid ${p.theme.tokens.border.primary};
box-shadow: ${p.theme.dropShadowMedium};
box-shadow: ${p.theme.shadow.medium};
padding: ${p.theme.space.xl};
`}
`;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ const CardIllustration = styled('img')`
object-fit: contain;
border: 1px solid ${p => p.theme.tokens.border.primary};
border-radius: ${p => p.theme.radius.md};
box-shadow: ${p => p.theme.dropShadowLight};
box-shadow: ${p => p.theme.shadow.low};
`;

const IntroText = styled('p')`
Expand Down
2 changes: 1 addition & 1 deletion static/gsAdmin/components/debounceSearch.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ const Card = styled('div')<{highlight?: boolean}>`
p.highlight
? p.theme.tokens.interactive.link.accent.active
: p.theme.tokens.content.primary};
box-shadow: ${p => p.theme.dropShadowMedium};
box-shadow: ${p => p.theme.shadow.medium};
padding: ${p => p.theme.space.xl};
`;
const Error = styled('div')`
Expand Down
2 changes: 1 addition & 1 deletion static/gsApp/components/ai/AiSetupDataConsent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ const SingleCard = styled('div')`
border-radius: ${p => p.theme.radius.md};
border: 1px solid ${p => p.theme.tokens.border.primary};
margin-top: ${p => p.theme.space.xl};
box-shadow: ${p => p.theme.dropShadowMedium};
box-shadow: ${p => p.theme.shadow.medium};
`;

const MeetSeerHeader = styled('div')`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ const Table = styled('table')`
border-radius: ${p => p.theme.radius.md};
border-collapse: separate;
border: 1px ${p => 'solid ' + p.theme.tokens.border.primary};
box-shadow: ${p => p.theme.dropShadowMedium};
box-shadow: ${p => p.theme.shadow.medium};
margin-bottom: ${p => p.theme.space.xl};
width: 100%;
`;
Expand Down
Loading