-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
ref(theme): migrate shadows #112997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ref(theme): migrate shadows #112997
Changes from all commits
78366d7
c75aa82
e15841e
ce87d06
4bed117
26c4ba8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ const StickyFooterBase = styled('div')` | |
| z-index: ${p => p.theme.zIndex.initial}; | ||
|
|
||
| &[data-stuck] { | ||
| box-shadow: ${p => p.theme.dropShadowHeavyTop}; | ||
| box-shadow: ${p => p.theme.shadow.high}; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Footer shadow direction changed from upward to downwardMedium Severity The old Additional Locations (1)Reviewed by Cursor Bugbot for commit 26c4ba8. Configure here. |
||
| } | ||
| `; | ||
|
|
||
|
|
||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inset keyword only applies to first shadow value
Medium Severity
box-shadow: inset ${theme.shadow.medium}prependsinsetto a multi-value shadow token. Sinceshadow.mediumexpands to two comma-separated shadows, theinsetkeyword only applies to the first one. The second shadow renders as an external (outset) drop shadow, which differs from the original single insetdropShadowMediumbehavior.Reviewed by Cursor Bugbot for commit 26c4ba8. Configure here.