fix(profiles): Use EAP spans instead of Transaction event on Profile landing page#112975
Draft
fix(profiles): Use EAP spans instead of Transaction event on Profile landing page#112975
Conversation
github-actions
bot
added
the
Scope: Frontend
Contributor
Sentry Snapshot Testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This beefy PR is almost entirely 1:1 property access replacements between the old transaction events and the new EAP spans approach. This affects the v1 (transaction-based) profile details page and the v2 (continuous) profile details page.
The only real new functionality is
static/app/utils/profiling/hooks/useTransaction.tsx, which is the new code to read the transaction-equivalent spans via EAP. Everything else is downstream data munging as a result of this change.Fixes DAIN-1465, DAIN-1466.