Skip to content

feat(seer): Implement sorting for the remaining columns on the Code Review settings table#112973

Open
ryan953 wants to merge 1 commit intomasterfrom
ryan953/seer-code-review-table-sorting
Open

feat(seer): Implement sorting for the remaining columns on the Code Review settings table#112973
ryan953 wants to merge 1 commit intomasterfrom
ryan953/seer-code-review-table-sorting

Conversation

@ryan953
Copy link
Copy Markdown
Member

@ryan953 ryan953 commented Apr 14, 2026

I also updated the button on the top-right to link over to the repositories page, so repos and provider can be managed directly, instead of in here.

@ryan953 ryan953 requested a review from a team as a code owner April 14, 2026 20:37
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 14, 2026
@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Apr 14, 2026

Sentry Snapshot Testing

Name Added Removed Modified Renamed Unchanged Status
sentry-frontend
sentry-frontend
0 0 0 0 204 ✅ Unchanged

@ryan953 ryan953 requested review from a team and billyvg April 14, 2026 20:42
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cc2c935. Configure here.

: b.settings?.enabledCodeReview
? -1
: 1;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent sort comparator for enabled field breaks sorting

Medium Severity

The enabled sort comparator violates the antisymmetry contract when comparing a repository with settings: null (enabledCodeReview is undefined) against one with enabledCodeReview: false. The equality check undefined === false evaluates to false, so they enter the unequal branch. But in that branch, for ascending, only a's value is checked — both undefined and false are falsy, so compare(A, B) and compare(B, A) both return 1. An inconsistent comparator can produce non-deterministic sort results.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit cc2c935. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants