feat(seer): Implement sorting for the remaining columns on the Code Review settings table#112973
feat(seer): Implement sorting for the remaining columns on the Code Review settings table#112973
Conversation
…eview settings table
Sentry Snapshot Testing
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cc2c935. Configure here.
| : b.settings?.enabledCodeReview | ||
| ? -1 | ||
| : 1; | ||
| } |
There was a problem hiding this comment.
Inconsistent sort comparator for enabled field breaks sorting
Medium Severity
The enabled sort comparator violates the antisymmetry contract when comparing a repository with settings: null (enabledCodeReview is undefined) against one with enabledCodeReview: false. The equality check undefined === false evaluates to false, so they enter the unequal branch. But in that branch, for ascending, only a's value is checked — both undefined and false are falsy, so compare(A, B) and compare(B, A) both return 1. An inconsistent comparator can produce non-deterministic sort results.
Reviewed by Cursor Bugbot for commit cc2c935. Configure here.


I also updated the button on the top-right to link over to the repositories page, so repos and provider can be managed directly, instead of in here.