feat(tracemetrics): Enable aggregate panel to show equation result#112966
Merged
narsaynorath merged 11 commits intomasterfrom Apr 15, 2026
Merged
feat(tracemetrics): Enable aggregate panel to show equation result#112966narsaynorath merged 11 commits intomasterfrom
narsaynorath merged 11 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
Contributor
Sentry Snapshot Testing
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
static/app/views/explore/metrics/hooks/useMetricAggregatesTable.tsx
Outdated
Show resolved
Hide resolved
static/app/views/explore/metrics/hooks/useMetricAggregatesTable.tsx
Outdated
Show resolved
Hide resolved
static/app/views/explore/metrics/metricInfoTabs/aggregatesTab.tsx
Outdated
Show resolved
Hide resolved
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/views/explore/metrics/metricInfoTabs/aggregatesTab.tsx
Outdated
Show resolved
Hide resolved
Member
Author
|
@cursor review |
static/app/views/explore/metrics/metricInfoTabs/aggregatesTab.tsx
Outdated
Show resolved
Hide resolved
static/app/views/explore/metrics/hooks/useMetricAggregatesTable.tsx
Outdated
Show resolved
Hide resolved
static/app/views/explore/metrics/hooks/useMetricAggregatesTable.tsx
Outdated
Show resolved
Hide resolved
static/app/views/explore/metrics/metricInfoTabs/aggregatesTab.tsx
Outdated
Show resolved
Hide resolved
DominikB2014
approved these changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bcb1671. Configure here.
narsaynorath
deleted the
nar/feat/tracemetrics-update-tables-in-metric-panel
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the aggregate panel is gated on stuff like
traceMetric.namebeing selected. This only applies to visualize functions and not equations, so this PR updates a bunch of the call sites to branch on the function-specific logic and add in equation logic (e.g. checking if the expression text is not empty)