feat(data-explore): Add new Query type for full export for simpler request validation#112953
feat(data-explore): Add new Query type for full export for simpler request validation#112953manessaraj wants to merge 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 929c5a4. Configure here.
| and export_format == OutputMode.JSONL.value | ||
| and len(base_fields) == 0 | ||
| ) | ||
| is_jsonl_trace_item_full_export = query_type == ExportQueryType.TRACE_ITEM_FULL_EXPORT_STR |
There was a problem hiding this comment.
Unused export_format parameter in _validate_query_info
Low Severity
The export_format parameter of _validate_query_info is now completely unused. It was previously needed to compute is_jsonl_trace_item_full_export (which checked export_format == OutputMode.JSONL.value), but that logic was replaced with a simple query_type check. The parameter is still declared in the signature and passed by all three callers in validate, making the code misleading — it implies the function's behavior depends on the export format when it no longer does.
Reviewed by Cursor Bugbot for commit 929c5a4. Configure here.


Create new Query type for full export of trace items for simpler query validation.