Skip to content

feat(data-explore): Add new Query type for full export for simpler request validation#112953

Open
manessaraj wants to merge 3 commits intomasterfrom
sarajmanes/feat/trace-items-full-export-new-query-type
Open

feat(data-explore): Add new Query type for full export for simpler request validation#112953
manessaraj wants to merge 3 commits intomasterfrom
sarajmanes/feat/trace-items-full-export-new-query-type

Conversation

@manessaraj
Copy link
Copy Markdown
Contributor

Create new Query type for full export of trace items for simpler query validation.

@manessaraj manessaraj requested a review from a team as a code owner April 14, 2026 17:50
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 14, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 929c5a4. Configure here.

and export_format == OutputMode.JSONL.value
and len(base_fields) == 0
)
is_jsonl_trace_item_full_export = query_type == ExportQueryType.TRACE_ITEM_FULL_EXPORT_STR
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused export_format parameter in _validate_query_info

Low Severity

The export_format parameter of _validate_query_info is now completely unused. It was previously needed to compute is_jsonl_trace_item_full_export (which checked export_format == OutputMode.JSONL.value), but that logic was replaced with a simple query_type check. The parameter is still declared in the signature and passed by all three callers in validate, making the code misleading — it implies the function's behavior depends on the export format when it no longer does.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 929c5a4. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant