Conversation
runningcode
approved these changes
Apr 14, 2026
Comment on lines
232
to
+235
|
|
||
| # Always run these tests | ||
| affected_test_files.update(ALWAYS_RUN_TESTS) | ||
|
|
Contributor
There was a problem hiding this comment.
Bug: Tests in ALWAYS_RUN_TESTS can be silently skipped if the file path is invalid, as they are filtered with Path.exists() without raising an error on failure.
Severity: HIGH
Suggested Fix
Either exempt files in ALWAYS_RUN_TESTS from the Path.exists() check, or modify the logic to raise an error and fail the CI job if a test from this list is not found. This ensures that missing critical tests do not go unnoticed.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/scripts/compute-sentry-selected-tests.py#L232-L235
Potential issue: The script ensures tests in `ALWAYS_RUN_TESTS` are always executed.
However, these tests are subjected to an existence check using `Path(f).exists()`. If a
test file from this list is renamed, deleted, or its relative path becomes invalid, it
is silently removed from the test suite. A debug message is logged, but the CI job does
not fail. This defeats the purpose of the `ALWAYS_RUN_TESTS` mechanism, as it could
allow breakages in critical tests to go unnoticed.
d9ad596 to
d5874b0
Compare
joshuarli
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I had added an
ALWAYS_RUN_TESTSconfig tocompute-selective-tests.pyin #112154 per Mark's request. At some point,compute-selective-tests.pywas deleted andcompute-sentry-selected-tests.pywas added, but thisALWAYS_RUN_TESTSwas not included.Today, a test breakage slipped through on master that this
ALWAYS_RUN_TESTSwould've caught (Slack), this re-adds the tests to always run.