-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(conversations): Show when a conversation happened on detail page #112910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
obostjancic
wants to merge
6
commits into
master
Choose a base branch
from
ognjenbostjancic/tet-2210-its-hard-to-see-when-the-conversation-happened-when-youre-on
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+33
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3c7bfe1
fix(conversations): Show timing on conversation details
obostjancic f5e7648
test(conversations): Relax timestamp assertion
obostjancic cd6082e
fix(conversations): Move last message timing into metadata row
obostjancic d998f16
fix(conversations): Reorder detail metadata
obostjancic 5b2c29a
Merge branch 'master' into ognjenbostjancic/tet-2210-its-hard-to-see-…
obostjancic 0b1545d
test(conversations): Remove summary component spec
obostjancic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The "Last message" timestamp in the summary reflects the last span's activity, not necessarily the last actual message, which can be misleading.
Severity: LOW
Suggested Fix
To ensure the "Last message" timestamp accurately reflects the last conversational turn, filter the
nodesarray to only include spans that represent user or assistant messages before finding the maximumend_timestamp. This will align the summary data with the user-facing messages.Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.