Skip to content

fix(ci): Select taskworker config test when task files change #112902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
runningcode wants to merge 1 commit into from
+12 −0
Closed

fix(ci): Select taskworker config test when task files change #112902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/scripts/compute-sentry-selected-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,12 @@
".github/CODEOWNERS": ["tests/sentry/api/test_api_owners.py"],
}

EXTRA_PATTERN_TO_TEST_MAPPING: list[tuple[re.Pattern[str], list[str]]] = [
# Filesystem-scanning tests can't be discovered via coverage.
# Any new task module must be registered in TASKWORKER_IMPORTS.
(re.compile(r"^src/sentry/.*tasks.*\.py$"), ["tests/sentry/taskworker/test_config.py"]),
]

EXCLUDED_TEST_PATTERNS: list[re.Pattern[str]] = [
re.compile(r"^tests/(acceptance|apidocs|js|tools)/"),
]
Expand Down Expand Up @@ -212,6 +218,12 @@ def main() -> int:
for f in changed:
affected_test_files.update(EXTRA_FILE_TO_TEST_MAPPING.get(f, []))

# Pattern-based extra mappings (e.g. new task files -> config tests)
for f in changed:
for pattern, extra_tests in EXTRA_PATTERN_TO_TEST_MAPPING:
if pattern.search(f):
affected_test_files.update(extra_tests)

# Directly changed test files
changed_tests = {
f
Expand Down
Loading