-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(explorer): stop UI polling after a timeout #112897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3c228c5
v0
aliu39 115bab0
use simplified polling state
aliu39 d14eee9
Merge branch 'master' into aliu/timeout-ui
aliu39 3558941
Merge branch 'aliu/timeout-ui' of github.com:getsentry/sentry into al…
aliu39 cc89ff3
jest test
aliu39 3dd1df0
fix on timeout effect
aliu39 d455899
fix optimistic effect on normal load
aliu39 c795960
only clear delete from index on first response block received
aliu39 1719847
Merge branch 'master' into aliu/timeout-ui
aliu39 6f3aeea
rm wasJustInterrupted for now
aliu39 35b2c44
separate on load effect from ontimeout
aliu39 50a9cae
clear optimistic and deletedfromindex on load/timeout
aliu39 ee82d9d
poll by default and integrate pr states into isLoaded
aliu39 4ada837
t wrapper
aliu39 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backtick key handler accidentally removed during refactor
Medium Severity
When
handleInputKeyDownwas refactored to useuseCallback, the backtick key guard was accidentally removed. The old code had an explicitif (e.key === '') { e.nativeEvent.stopImmediatePropagation(); }block to prevent the backtick from triggering the superuserViewAsHookMiddleware`. This protection is now missing, so typing a backtick in the input while focused will propagate the event and potentially toggle superuser mode for staff users.Reviewed by Cursor Bugbot for commit cc89ff3. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it didnt work