feat(tracemetrics): Do not allow deletion of metrics used in equations#112893
Open
narsaynorath wants to merge 4 commits intomasterfrom
Open
feat(tracemetrics): Do not allow deletion of metrics used in equations#112893narsaynorath wants to merge 4 commits intomasterfrom
narsaynorath wants to merge 4 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
Contributor
Sentry Snapshot Testing
|
| return ( | ||
| v && | ||
| isVisualizeEquation(v) && | ||
| v.expression.tokens.some(token => token.text === functionString) |
Member
There was a problem hiding this comment.
Using some sort of entity-specific ID (not order-dependent labels) would be good IMO.
Member
Author
There was a problem hiding this comment.
@JoshuaKGoldberg Okay I think I fixed this! Before I was just naively doing a string match on the aggregate in string form, but this meant that queries that were the same would just be treated as "in-use". Now the equation builder calls a callback to set what references are being used and then passes down the set of used references that I can use with the query label to know which one is used. Would you mind helping me with a review when you get a chance? Thanks!
Member
Author
|
Drafting to fix merge conflicts, fix bug, etc |
Base automatically changed from
nar/feat/tracemetrics-use-references-as-intermediate-representation
to
master
April 14, 2026 16:48
To avoid invalid states, avoid deleting metrics that are used in equations.
narsaynorath
force-pushed
the
nar/feat/tracemetrics-do-not-allow-deletion-of-metrics-in-equations
branch
from
372190a to
9f13618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid invalid states, avoid deleting metrics that are used in equations.