feat(data-export): Exported attributes in data export should have public names#112846
Open
manessaraj wants to merge 4 commits intomasterfrom
Open
feat(data-export): Exported attributes in data export should have public names#112846manessaraj wants to merge 4 commits intomasterfrom
manessaraj wants to merge 4 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
manessaraj
changed the title
manessaraj
force-pushed
the
sarajmanes/feat/trace-items-full-export-only-public-names
branch
from
bedcd41 to
4bcd863
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
wmak
reviewed
Apr 13, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
manessaraj
force-pushed
the
sarajmanes/feat/trace-items-full-export-only-public-names
branch
from
71c78dc to
2b94237
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4315543. Configure here.
wmak
reviewed
Apr 15, 2026
| eap_storage_type: Literal["string", "number", "boolean"], | ||
| item_type: SupportedTraceItemType, | ||
| ) -> str: | ||
| # eap_storage_type is not same as search_type used in translate_internal_to_public_alias |
Member
There was a problem hiding this comment.
I'm confused, when you say search_type here do you mean the second parameter to translate_internal_to_public_alias? How does it differ, aren't we calculating eap_search_type from eap_storage_scalar_type_from_protobuf specifically to use it here?
manessaraj
force-pushed
the
sarajmanes/feat/trace-items-full-export-only-public-names
branch
from
4315543 to
2230bd5
Compare
…lic names Exported attributes in full export of trace items should have public and user defined tags, no internal representation should be exposed
manessaraj
force-pushed
the
sarajmanes/feat/trace-items-full-export-only-public-names
branch
from
2230bd5 to
8187e9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exported attributes in full export of trace items should have public and user defined tags, no internal representation should be exposed