feat(integrations): Send SLO lifecycle metrics to Sentry via SDK#112839
Merged
feat(integrations): Send SLO lifecycle metrics to Sentry via SDK#112839
Conversation
Adds a direct sentry_sdk.metrics.count() call alongside the existing metrics.incr() in record_event() so SLO metrics (started, success, halted, failure) are sent to Sentry at 100% with integration_id, bypassing the DualWrite experimental backend's 5% sample rate.
github-actions
bot
added
the
Scope: Backend
armenzg
approved these changes
Apr 13, 2026
Contributor
|
PR reverted: 7e3195c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sentry_sdk.metrics.count()call inEventLifecycle.record_event()so SLO metrics (started,success,halted,failure) are sent to Sentry's metrics product at 100% withintegration_idincluded as a tag.metrics.incr()call (Datadog) is untouched.DualWriteMetricsBackendexperimental backend which only samples at 5%, giving us full-fidelity SLO data in Sentry without the cardinality cost on Datadog.Companion PR in seer: https://github.com/getsentry/seer/pull/new/telkins/slo-sentry-metrics
Test plan
sentry.integrations.slo.startedwithintegration_idtag