fix(iswf): Adds KID validation to Bitbucket Connect installation webhook#112833
Open
GabeVillalobos wants to merge 5 commits intomasterfrom
Open
fix(iswf): Adds KID validation to Bitbucket Connect installation webhook#112833GabeVillalobos wants to merge 5 commits intomasterfrom
GabeVillalobos wants to merge 5 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
GabeVillalobos
commented
Apr 13, 2026
Comment on lines
-64
to
-67
| if not key_id: | ||
| lifecycle.record_halt(halt_reason="Missing key_id (kid)") | ||
| return self.respond( | ||
| {"detail": "Missing key id"}, status=status.HTTP_400_BAD_REQUEST |
Member
Author
There was a problem hiding this comment.
Refactored this all into a common class. I simplified some of the response logic to be a bit more intentionally vague but also more consistent across failure modes.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
saponifi3d
approved these changes
Apr 14, 2026
| assert_count_of_metric(mock_record_event, EventLifecycleOutcome.STARTED, 3) | ||
| assert_count_of_metric(mock_record_event, EventLifecycleOutcome.HALTED, 1) | ||
| assert_count_of_metric(mock_record_event, EventLifecycleOutcome.SUCCESS, 2) | ||
| assert_halt_metric(mock_record_event, "Expired signature") |
Contributor
There was a problem hiding this comment.
super nit: might be nice to have Expired Signature as a EventLifecycleOutcome or something along those lines?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves ISWF-2359