Skip to content

feat(source-map-config-issues): Adding Sentry Configuration nav item under issues#112811

Merged
Abdkhan14 merged 16 commits intomasterfrom
abdk/source-map-config-issues-nav
Apr 15, 2026
Merged

feat(source-map-config-issues): Adding Sentry Configuration nav item under issues#112811
Abdkhan14 merged 16 commits intomasterfrom
abdk/source-map-config-issues-nav

Conversation

@Abdkhan14
Copy link
Copy Markdown
Contributor

Screenshot 2026-04-13 at 10 53 26 PM

@Abdkhan14 Abdkhan14 requested a review from a team as a code owner April 13, 2026 16:54
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 13, 2026
@Abdkhan14 Abdkhan14 changed the title Abdk/source map config issues nav feat(source-map-config-issues): Adding Sentry Configuration nav item under issues Apr 13, 2026
'Issues in your code or configuration that may not break functionality but can degrade performance or user experience'
),
},
[IssueTaxonomy.SENTRY_CONFIGURATION]: {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like by adding this item to ISSUE_TAXONOMY_CONFIG it gets unconditionally rendered here

{Object.values(ISSUE_TAXONOMY_CONFIG).map(({key, label}) => (
, does it need to be feature flagged?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Laser review man, thanks

Added a feature flag gating to the nav item and the route itself

@Abdkhan14 Abdkhan14 requested a review from a team as a code owner April 14, 2026 11:51
@sentry
Copy link
Copy Markdown
Contributor

sentry bot commented Apr 14, 2026

Sentry Snapshot Testing

Name Added Removed Modified Renamed Unchanged Status
sentry-frontend
sentry-frontend
0 0 0 0 204 ✅ Unchanged

Comment thread static/app/views/issueList/pages/sentryConfiguration.tsx
Comment thread static/app/views/issueList/pages/sentryConfiguration.tsx Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 653b66a. Configure here.

Comment thread static/app/views/issueList/taxonomies.tsx
Comment thread static/app/views/issueList/taxonomies.tsx
Base automatically changed from abdk/config-issues-impact-section-ui to master April 14, 2026 16:16
@Abdkhan14 Abdkhan14 requested a review from a team as a code owner April 14, 2026 16:19
@Abdkhan14 Abdkhan14 requested a review from jaydgoss April 14, 2026 16:20
/>
))}
{Object.values(ISSUE_TAXONOMY_CONFIG)
.filter(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might be worth extracting this filter to a helper since its used in multiple places

@Abdkhan14 Abdkhan14 merged commit 226ff7a into master Apr 15, 2026
64 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/source-map-config-issues-nav branch April 15, 2026 09:26
gggritso added a commit that referenced this pull request Apr 15, 2026
The merge resolution incorrectly dropped the .filter() on
ISSUE_TAXONOMY_CONFIG that gates entries by their featureFlag.
This was added on master in #112811 for the Sentry Configuration
taxonomy entry. Restore it to avoid exposing gated features.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants