chore(flags): Remove unused organizations:performance-use-metrics feature flag#112758
Merged
chore(flags): Remove unused organizations:performance-use-metrics feature flag#112758
Conversation
github-actions
bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
wedamija
force-pushed
the
danf/remove-performance-use-metrics
branch
from
5254211 to
3584163
Compare
wedamija
commented
Apr 11, 2026
| {}, | ||
| { | ||
| features: ['performance-use-metrics'], | ||
| features: ['dynamic-sampling'], |
Member
Author
There was a problem hiding this comment.
This is just another flag that allows canUseMetricsData to return true
wedamija
force-pushed
the
danf/remove-performance-use-metrics
branch
from
3584163 to
9d849f9
Compare
Member
Author
|
@k-fish I think you have the most context here, is this safe to remove? |
wedamija
force-pushed
the
danf/remove-performance-use-metrics
branch
from
9d849f9 to
56fe506
Compare
This comment was marked as outdated.
This comment was marked as outdated.
…ture flag As far as I can tell, `organizations:performance-use-metrics` is totally unused. I checked the options in all STs and it was enabled for org 1 in only one of them, and completely disabled elsewhere. Just removing this code, but would appreciate if folks involved could confirm that it's really not used.
Contributor
Sentry Snapshot Testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell,
organizations:performance-use-metricsis totally unused. I checked the options in all STs and it was enabled for org 1 in only one of them, and completely disabled elsewhere. Just removing this code, but would appreciate if folks involved could confirm that it's really not used.Getsentry pr: https://github.com/getsentry/getsentry/pull/19865