fix(aci): Fix bug with github action settings#112742
Merged
saponifi3d merged 5 commits intomasterfrom Apr 10, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Frontend
malwilley
approved these changes
Apr 10, 2026
Member
malwilley
left a comment
malwilley
left a comment
There was a problem hiding this comment.
Have a comment about the test, but application code looks good 👍
| import {TicketActionSettingsButton} from 'sentry/views/automations/components/actions/ticketActionSettingsButton'; | ||
| import {AutomationFormProvider} from 'sentry/views/automations/components/forms/context'; | ||
|
|
||
| jest.mock('sentry/actionCreators/modal'); |
Member
There was a problem hiding this comment.
Instead of mocking openModal(), you can use renderGlobalModal() and then you can test everything without mocks. If possible, that would be a more robust test case
Contributor
Author
There was a problem hiding this comment.
thanks! i didn't really like the way it was depending on that; let me know whatcha think of this update with renderGlobalModal
malwilley
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will fix an issue where github settings weren't showing up in the form component.
Screen.Recording.2026-04-10.at.1.48.39.PM.mov
Fixes ISWF-851