ref(onboarding): Add useIntegrationLauncher hook for multi-provider flows#112741
Closed
jaydgoss wants to merge 1 commit intojaygoss/vdy-69-scm-more-dropdownfrom
Closed
ref(onboarding): Add useIntegrationLauncher hook for multi-provider flows#112741jaydgoss wants to merge 1 commit intojaygoss/vdy-69-scm-more-dropdownfrom
jaydgoss wants to merge 1 commit intojaygoss/vdy-69-scm-more-dropdownfrom
Conversation
…lows Add a standalone hook that accepts the provider at call time instead of at initialization. This replaces the hidden-child registration pattern in ScmProvidersDropdown, which mounted one component per provider purely to call useAddIntegration and stash callbacks in a ref map. The new hook owns a single message listener and popup reference, handling both legacy popup and pipeline modal paths. Existing useAddIntegration callers are unaffected.
github-actions
bot
added
the
Scope: Frontend
4 tasks
Member
|
oh, this looks similar in intent to #112766 |
Member
There was a problem hiding this comment.
Seems like we could actually just refactor useIntegration to have this API, there's not too many call-sites I think so it wouldn't be a huge lift right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useIntegrationLauncherhook that accepts the provider at call time instead of at initialization, suitable for data-driven UIs like dropdownsScmProvidersDropdown(which mounted one invisible component per provider to stash callbacks in a ref map) with a single hook callcomputeCenteredWindowandgetApiPipelineProviderfromaddIntegration.tsx(no behavior change) so the new hook can reuse themStacks on #112730.
Refs VDY-69
PR Stack
Test plan
addIntegrationtests pass (13/13)scmProviderPillstests pass (4/4)