Skip to content

feat(snapshots): Show diff_threshold in snapshot detail header#112740

Merged
NicoHinderling merged 1 commit intomasterfrom
feat/snapshot-diff-threshold-ui
Apr 10, 2026
Merged

feat(snapshots): Show diff_threshold in snapshot detail header#112740
NicoHinderling merged 1 commit intomasterfrom
feat/snapshot-diff-threshold-ui

Conversation

@NicoHinderling
Copy link
Copy Markdown
Contributor

@NicoHinderling NicoHinderling commented Apr 10, 2026

CleanShot 2026-04-10 at 14 08 50@2x

Summary

Surfaces the optional diff_threshold value from the snapshot manifest in the snapshot detail API response and renders it in the header UI next to the branch name when set.

  • Backend: Added diff_threshold field to SnapshotDetailsApiResponse model, populated from the manifest
  • Frontend: Added diff_threshold to the TypeScript type, rendered with a settings icon as "Diff threshold: X.X%" in the header

When diff_threshold is not set (most snapshots), nothing changes in the UI.

Refs EME-406

Test plan

  • Load a snapshot that has diff_threshold set in its manifest — verify it shows "Diff threshold: X.X%" next to the branch name
  • Load a snapshot without diff_threshold — verify no extra element appears in the header

@NicoHinderling NicoHinderling requested a review from a team as a code owner April 10, 2026 21:02
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 10, 2026

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Comment thread src/sentry/preprod/api/endpoints/preprod_artifact_snapshot.py
@NicoHinderling NicoHinderling force-pushed the feat/snapshot-diff-threshold-ui branch from 7820557 to b110cc3 Compare April 10, 2026 21:03
@NicoHinderling NicoHinderling changed the base branch from master to 04-10-ref_snapshots_add_configurable_diff_threshold_for_snapshot_comparison April 10, 2026 21:04
@NicoHinderling NicoHinderling force-pushed the feat/snapshot-diff-threshold-ui branch from b110cc3 to d6378ca Compare April 10, 2026 21:08
@NicoHinderling NicoHinderling force-pushed the 04-10-ref_snapshots_add_configurable_diff_threshold_for_snapshot_comparison branch 2 times, most recently from df7a12d to 418c4ee Compare April 10, 2026 21:30
Base automatically changed from 04-10-ref_snapshots_add_configurable_diff_threshold_for_snapshot_comparison to master April 10, 2026 21:52
@NicoHinderling NicoHinderling force-pushed the feat/snapshot-diff-threshold-ui branch from d6378ca to a3c2aa0 Compare April 10, 2026 22:12
@NicoHinderling NicoHinderling merged commit ecd19d5 into master Apr 10, 2026
60 checks passed
@NicoHinderling NicoHinderling deleted the feat/snapshot-diff-threshold-ui branch April 10, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants