fix(explore): Pass sort param for group-by explore Slack unfurls#112704
Merged
DominikB2014 merged 1 commit intomasterfrom Apr 10, 2026
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 461b824. Configure here.
When an Explore link with groupBy is unfurled in Slack, the unfurl sets topEvents=5 but omits the sort parameter. Without it, the timeseries endpoint returns whichever groups it defaults to rather than the top groups matching what Explore shows. Now copies the aggregateSort URL param (Explore's name) as sort (the API name), and defaults to descending by the charted yAxis when no explicit sort is present — matching the frontend's behavior. Fixes DAIN-1490 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DominikB2014
force-pushed
the
dominikbuszowiecki/dain-1490-incorrect-data-with-group-by
branch
from
461b824 to
209d23c
Compare
edwardgou-sentry
approved these changes
Apr 10, 2026
DominikB2014
deleted the
dominikbuszowiecki/dain-1490-incorrect-data-with-group-by
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an Explore link with
groupByis unfurled in Slack, the unfurl setstopEvents=5but omits thesortparameter. Without it, the timeseriesendpoint returns whichever groups it defaults to rather than the actual top
groups matching what Explore shows (e.g., "mark" and "paint" appearing
instead of the real top groups).
Two changes:
map_explore_query_argsnow copies theaggregateSortURL param(Explore's name) as
sort(the API param name)_unfurl_exploredefaults to-{yAxis}(descending by the chartedaggregate) when no explicit sort is present, matching the frontend's
defaultAggregateSortBysbehaviorFixes DAIN-1490