chore(ci): Remove unused navigate-only acceptance tests#112698
Merged
chore(ci): Remove unused navigate-only acceptance tests#112698
Conversation
rbro112
changed the title
JoshFerge
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance tests are now our primary bottleneck on CI time since selective testing has landed. To start, I audited the existing acceptance tests to see what we could immediately remove.
Upon investigation, I found many navigate-only tests. I deem these tests as useless as navigations without assertions don't actually validate any functionality. It's very likely these were around for legacy visual snapshot testing with Percy, but never properly removed.
Additionally, there's quite a few skipped tests that are stale, so I also removed those.
This PR removes any navigate-only tests, which will reduce the total amount of acceptance tests by ~50.