Skip to content

fix(incidents): Fix 60x resolution inflation when switching to DYNAMIC detection without explicit time_window #112695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcons merged 1 commit into from
Apr 10, 2026
Merged

fix(incidents): Fix 60x resolution inflation when switching to DYNAMIC detection without explicit time_window #112695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/sentry/incidents/logic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,9 +918,11 @@ def update_alert_rule(
updated_fields["seasonality"] = None
elif detection_type == AlertRuleDetectionType.DYNAMIC:
# NOTE: we set seasonality for EA
updated_query_fields["resolution"] = timedelta(
minutes=time_window if time_window is not None else snuba_query.time_window
)
if time_window is not None:
updated_query_fields["resolution"] = timedelta(minutes=time_window)
else:
# snuba_query.time_window is already in seconds
updated_query_fields["resolution"] = timedelta(seconds=snuba_query.time_window)
updated_fields["seasonality"] = AlertRuleSeasonality.AUTO
updated_fields["comparison_delta"] = None
if (
Expand Down
21 changes: 21 additions & 0 deletions tests/sentry/incidents/test_logic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,6 +1541,27 @@ def test_update_alert_rule_static_to_dynamic_enough_data(
assert mock_seer_request.call_count == 1
assert alert_rule.status == AlertRuleStatus.PENDING.value

@with_feature("organizations:anomaly-detection-alerts")
@patch("sentry.seer.anomaly_detection.store_data.handle_send_historical_data_to_seer_legacy")
def test_update_static_to_dynamic_without_time_window_preserves_resolution(
self, mock_handle_seer: MagicMock
) -> None:
time_window_minutes = 30
alert_rule = self.create_alert_rule(
time_window=time_window_minutes, detection_type=AlertRuleDetectionType.STATIC
)
expected_resolution_seconds = time_window_minutes * 60

update_alert_rule(
alert_rule,
sensitivity=AlertRuleSensitivity.HIGH,
seasonality=AlertRuleSeasonality.AUTO,
detection_type=AlertRuleDetectionType.DYNAMIC,
)

alert_rule.snuba_query.refresh_from_db()
assert alert_rule.snuba_query.resolution == expected_resolution_seconds

@with_feature("organizations:anomaly-detection-alerts")
@patch(
"sentry.seer.anomaly_detection.store_data.seer_anomaly_detection_connection_pool.urlopen"
Expand Down
Loading