feat(eslint): no-unnecessary-use-callback

[TkDodo]

This PR adds a new lint rule, no-unnecessary-use-callback, that only checks if useCallback is unnecessary in 3 scenarios:

1. The only usage is a direct invocation:

const fn = useCallback(() => ..., [deps])

<Component onClick={() => fn()} />

This is unnecessary because the referential stability of fn is never “consumed”.

2. They are passed to react intrinsic elements

const fn = useCallback(() => ..., [deps])

<button onClick={fn} />

React intrinsic elements like button never expect props to be memoized, the components themselves are not memoized so the useCallback does nothing.

3. They pare passed to scraps components. Scraps components, too, don’t expect consumers to memoize input:

const fn = useCallback(() => ..., [deps])

<LinkButton onClick={fn} />

all other cases are left as they are. Still, there were 194 violations of this new rule, which were auto fixed.

[JoshuaKGoldberg]

This is fantastic! 👏 🔥 I'm so pumped to get this in and see the code cleanups. And hopefully eventually get it merged into React lint rule packages upstream.

No blockers, just a few small suggestions that can be taken or leaven.

[JoshuaKGoldberg]

[Non-Blocking] Just noting, handleDismiss is only used once, in a single callback later on that calls it and runs window.location.hash = '';. Another solution could be to move that location setter inside handleDismiss.

...but also not a blocker at all for this PR IMO. Maybe a good other lint rule to noodle on.

[JoshuaKGoldberg]

[Bug] Checking node names is susceptible to bugs caused by variable shadowing. It'd really be better to use

Here's an example commit with four incorrect tests: c148a13

If this were a fully shared open source project I'd request changes. But I don't think the Sentry codebase tends to do this particular shadowing weirdness. IMO it's fine for now.

[sentry]

Sentry Snapshot Testing

Name	Added	Removed	Modified	Renamed	Unchanged	Status
sentry-frontend sentry-frontend	0	0	0	0	204	✅ Unchanged

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 370dc0e. Configure here.}

[cursor]

Exclusion check uses local name instead of imported name

Low Severity

The scrapsExclusions check uses spec.local.name (the local alias) instead of the original imported name. For aliased imports like import {CompactSelect as CS} from '@sentry/scraps/compactSelect', the exclusion check against 'CS' won't match 'CompactSelect' in the set, so CS gets added to scrapsImports. The rule would then incorrectly flag useCallback passed to <CS onChange={fn} /> as unnecessary, even though CompactSelect is explicitly excluded because it internally depends on memoized callbacks.

 

^{Reviewed by Cursor Bugbot for commit 370dc0e. Configure here.}