feat(onboarding): Pre-populate repo selector with full repo list#112685
Merged
feat(onboarding): Pre-populate repo selector with full repo list#112685
Conversation
github-actions
bot
added
the
Scope: Frontend
jaydgoss
force-pushed
the
jaygoss/vdy-46-scm-repo-selector-FE-browse
branch
from
95640d7 to
f2bc339
Compare
jaydgoss
force-pushed
the
jaygoss/vdy-46-scm-repo-selector-FE-browse
branch
from
f2bc339 to
bc8e69f
Compare
jaydgoss
force-pushed
the
jaygoss/vdy-46-scm-repo-selector-FE-browse
branch
2 times, most recently
from
e161280 to
cc153f7
Compare
Load the complete list of accessible repositories on mount so users can browse and select without typing first. Search still narrows results server-side when the user types. Previously the dropdown was empty until a search query was entered, requiring users to know what to search for. Refs VDY-46
jaydgoss
force-pushed
the
jaygoss/vdy-46-scm-repo-selector-FE-browse
branch
from
cc153f7 to
e6323e4
Compare
Tests expected the old search-driven behavior where data only loaded after typing. Now that repos fetch on mount, update mocks and assertions to match. Add a fallback in ScmVirtualizedMenuList for when the virtualizer cannot measure the container (jsdom has no layout engine).
Use the same @tanstack/react-virtual mock as scmPlatformFeatures tests instead of a runtime fallback in the component. Reverts the jsdom fallback in ScmVirtualizedMenuList.
Update comment to reflect the new fetch-on-mount model instead of referencing server-side search results. Bump staleTime from 20s to 60s since the repo list is now fetched once and filtered client-side.
evanpurkhiser
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch the complete list of repositories on mount so users can browse and select without typing first. The Select component handles filtering client-side when the user types, so there is no server-side search round-trip.
Previously the dropdown was empty until a search query was entered, requiring users to already know the repo name. Adds the virtualized menu list component to keep the dropdown performant with large repo lists.
Refs VDY-46