-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
ref(nav): migrate breadcrumbs to TopBar.Title
#112672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f9e0415
8516fa1
1889742
db9b4a3
1c6c0d8
60930f2
cf7b8a9
dbf04fd
6f5d852
5fbb7cd
2d2688c
f628183
03bce42
ec751e9
6b41450
e4f9f2d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,8 +10,10 @@ import {makeTracesPathname} from 'sentry/views/traces/pathnames'; | |
|
|
||
| export function ExploreBreadcrumb({ | ||
| traceItemDataset, | ||
| savedQueryName, | ||
| }: { | ||
| traceItemDataset: TraceItemDataset; | ||
| savedQueryName?: string; | ||
| }) { | ||
| const organization = useOrganization(); | ||
| const crumbs: Crumb[] = []; | ||
|
|
@@ -40,7 +42,7 @@ export function ExploreBreadcrumb({ | |
| }); | ||
| } | ||
| crumbs.push({ | ||
| label: t('Saved Query'), | ||
| label: savedQueryName ?? t('Saved Query'), | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nullish coalescing allows empty string breadcrumb labelLow Severity The Reviewed by Cursor Bugbot for commit 6b41450. Configure here.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Edge case |
||
| }); | ||
|
|
||
| return <Breadcrumbs crumbs={crumbs} />; | ||
|
|
||


Uh oh!
There was an error while loading. Please reload this page.