Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| } | ||
|
|
||
| return ( | ||
| <ConstrainedPage |
There was a problem hiding this comment.
Missing flex growth causes constrained page to collapse
High Severity
Switching from Layout.Page to Layout.Main drops the flex="1" that Layout.Page provides via its Stack wrapper. Layout.Main renders a plain Container with no flex-grow behavior. In the constrained path, ConstrainedMain applies contain: size (which makes the element's intrinsic size zero) and minHeight="0". Without flex="1" to grow within the parent flex container (Layout.Page), this element collapses to zero height, making the logs page content invisible. The non-constrained path is also affected — the content won't fill remaining vertical space — though at least children remain visible. A flex="1" prop needs to be passed to Layout.Main in both paths.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 46689a5. Configure here.
There was a problem hiding this comment.
this is a valid feedback
but other than that, it looks good!
Make the errors page main wrapper and viewport-constrained logs wrapper explicit flex columns so explore body sections can grow to fill the remaining page height. This preserves Layout.Main's existing behavior for the rest of the app while fixing the logs and errors pages that depend on flex-based body sizing. Co-Authored-By: Codex <codex@openai.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6b4b5bb. Configure here.
| display: flex; | ||
| flex-direction: column; | ||
| min-height: 0; | ||
| `; |
There was a problem hiding this comment.
Duplicated styled component across two files
Low Severity
ErrorsPageMain is an exact duplicate of FlexMain from viewportConstrainedPage.tsx — same base component (Layout.Main), same CSS (display: flex; flex-direction: column; min-height: 0). The errors page could reuse FlexMain (if exported) or use ViewportConstrainedPage with constrained={false} instead of duplicating the styled component.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 6b4b5bb. Configure here.
| const FlexMain = styled(Layout.Main)` | ||
| display: flex; | ||
| flex-direction: column; | ||
| min-height: 0; | ||
| `; |
There was a problem hiding this comment.
shouldn’t we use a Flex with render prop instead of custom styled ?
There was a problem hiding this comment.
I should add a lint rule just to prevent myself from doing this at this point
3 participants
Layout.Page is already defined at the root most OrgLayout, re-using it here causes
main > mainDOM structure and with page-frame feature enabled, causes double border on logs and some errors page.