fix(seer): Decouple create-pr setting from stopping point#112646
Merged
fix(seer): Decouple create-pr setting from stopping point#112646
Conversation
github-actions
bot
added
the
Scope: Frontend
billyvg
reviewed
Apr 10, 2026
| const tuning = stoppingPoint === 'off' ? ('off' as const) : ('medium' as const); | ||
| ProjectsStore.onUpdateSuccess({...project, autofixAutomationTuning: tuning}); | ||
|
|
||
| if (stoppingPoint !== 'off' && previousPreference?.preference) { |
Member
There was a problem hiding this comment.
Why do we not update when it's off?
Member
Author
There was a problem hiding this comment.
added a comment to answer
TL/DR I hate these api endpoints... can't wait until they're changed
optionall, nullable, nested objects, but also things spread across ProjectOptions and the SeerPreferences model. fml
billyvg
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This decouples the Create PR setting from the Stopping Point value, and adds some optimistic updates to make the ui feel snappier.
This hook applies to the Autofix Project details page only, no other imports.